Closed Bug 869100 Opened 7 years ago Closed 7 years ago

complete token bucket a/b test

Categories

(Core :: Networking: HTTP, defect)

20 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

Attachments

(1 file)

This patch removes the A/B testing for the Token Bucket implementation.

With one exception, the data didn't really show any differences. The one exception was a configuration that relied only on reduced parallelism and a very slow token bucket - that profile was slower in the data than the others. So we can say that the token bucket doesn't regress things. I think it doesn't show an improvement, where it clearly does in targetted local testing, simply because the enhancement only applies to a certain edge cast which is not yet very common. I expect it to become more common in the future as data sizes increase and IW=10 becomes more common.
Blocks: 819734
Attached patch patch 0Splinter Review
Attachment #745979 - Flags: review?(honzab.moz)
Attachment #745979 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/mozilla-central/rev/5566cebc8766
Assignee: nobody → mcmanus
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.