Closed Bug 869206 Opened 7 years ago Closed 6 years ago

Make webrtc code build on gonk-JB

Categories

(Core :: WebRTC, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: mwu, Assigned: mwu)

References

Details

(Whiteboard: [fixed-in-birch][WebRTC][blocking-webrtc-][qa-])

Attachments

(1 file)

Right now, we disable camera on JB gonk, so this patch allows the webrtc code to build in that configuration. It also disables including "modules/audio_device/android/audio_device_jni_android.h" since that isn't around on JB gonk.
Attachment #746097 - Flags: review?(rjesup)
Comment on attachment 746097 [details] [diff] [review]
Make webrtc code work on JB

Review of attachment 746097 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but I'd like to find a way to refactor out the specific ifndef of B2G in an imported webrtc file (i.e. source files in media/webrtc/trunk), or at least restrict it to a gyp file (even more preferably to common.gypi or triggered via a setting in media/webrtc/webrtc_config.gypi).  Please file a followup bug to do so.
Attachment #746097 - Flags: review?(rjesup) → review+
Blocks: 869211
https://hg.mozilla.org/projects/birch/rev/6240212ff179
Whiteboard: [fixed-in-birch]
Whiteboard: [fixed-in-birch] → [fixed-in-birch][WebRTC][blocking-webrtc-]
https://hg.mozilla.org/mozilla-central/rev/6240212ff179
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Whiteboard: [fixed-in-birch][WebRTC][blocking-webrtc-] → [fixed-in-birch][WebRTC][blocking-webrtc-][qa-]
You need to log in before you can comment on or make changes to this bug.