Closed
Bug 869206
Opened 11 years ago
Closed 11 years ago
Make webrtc code build on gonk-JB
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: mwu, Assigned: mwu)
References
Details
(Whiteboard: [fixed-in-birch][WebRTC][blocking-webrtc-][qa-])
Attachments
(1 file)
|
9.00 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
Right now, we disable camera on JB gonk, so this patch allows the webrtc code to build in that configuration. It also disables including "modules/audio_device/android/audio_device_jni_android.h" since that isn't around on JB gonk.
Attachment #746097 -
Flags: review?(rjesup)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 746097 [details] [diff] [review]
Make webrtc code work on JB
Review of attachment 746097 [details] [diff] [review]:
-----------------------------------------------------------------
r+, but I'd like to find a way to refactor out the specific ifndef of B2G in an imported webrtc file (i.e. source files in media/webrtc/trunk), or at least restrict it to a gyp file (even more preferably to common.gypi or triggered via a setting in media/webrtc/webrtc_config.gypi). Please file a followup bug to do so.
Attachment #746097 -
Flags: review?(rjesup) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
Whiteboard: [fixed-in-birch]
|
||
Updated•11 years ago
|
Whiteboard: [fixed-in-birch] → [fixed-in-birch][WebRTC][blocking-webrtc-]
|
||
Comment 3•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
|
||
Updated•11 years ago
|
Whiteboard: [fixed-in-birch][WebRTC][blocking-webrtc-] → [fixed-in-birch][WebRTC][blocking-webrtc-][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•