Closed Bug 869234 Opened 7 years ago Closed 7 years ago
No barriers are needed on the LIR graph's constant pool
LIRGraph's constpool is not tied to the lifetime of a GC thing, and the memory can move, so it is not safe to have the members be HeapPtrs. Since GC is suppressed any time we have a live LIRGraph, the best solution is to just make these Values.
Attachment #746127 - Flags: feedback?(wmccloskey) → feedback+
Attachment #746127 - Flags: review?(bhackett1024) → review+
Green try run: https://tbpl.mozilla.org/?tree=Try&rev=8ea3d8d7ce1d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.