Closed Bug 869234 Opened 7 years ago Closed 7 years ago

No barriers are needed on the LIR graph's constant pool

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v0 (obsolete) — Splinter Review
LIRGraph's constpool is not tied to the lifetime of a GC thing, and the memory can move, so it is not safe to have the members be HeapPtrs. Since GC is suppressed any time we have a live LIRGraph, the best solution is to just make these Values.
Attachment #746127 - Flags: review?(bhackett1024)
Attachment #746127 - Flags: feedback?(wmccloskey)
Attachment #746127 - Flags: feedback?(wmccloskey) → feedback+
Attachment #746127 - Flags: review?(bhackett1024) → review+
Attachment #746127 - Attachment is obsolete: true
Attachment #747052 - Flags: review+
Whiteboard: [checkin-needed]
https://hg.mozilla.org/mozilla-central/rev/3dea7cce5f64
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.