Closed
Bug 869234
Opened 12 years ago
Closed 12 years ago
No barriers are needed on the LIR graph's constant pool
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.31 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
LIRGraph's constpool is not tied to the lifetime of a GC thing, and the memory can move, so it is not safe to have the members be HeapPtrs. Since GC is suppressed any time we have a live LIRGraph, the best solution is to just make these Values.
Attachment #746127 -
Flags: review?(bhackett1024)
Attachment #746127 -
Flags: feedback?(wmccloskey)
Attachment #746127 -
Flags: feedback?(wmccloskey) → feedback+
|
||
Updated•12 years ago
|
Attachment #746127 -
Flags: review?(bhackett1024) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
Green try run: https://tbpl.mozilla.org/?tree=Try&rev=8ea3d8d7ce1d
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #746127 -
Attachment is obsolete: true
Attachment #747052 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [checkin-needed]
|
||
Comment 3•12 years ago
|
||
Whiteboard: [checkin-needed]
|
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•