869292 - [Video] Need to be able to save from the "open" activity window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect, P1)

Description

[Dominic Kuo [:dkuo]]

When a video file is opened by the video player via open activity, the user has the option to "save" that content, if the user selects that option, a banner indicating the success/failure of the operation is shown when completed.

Currently this feature will be used with SMS/MMS and email apps.

Comment 1

[Dominic Kuo [:dkuo]]

I should be able to implement this, however anyone is welcome to take it. I am assigning this to myself in case this bug needs status update or LOE estimation.

Comment 2

[David Flanagan [:djf]]

Attachment: link to patch on github

Dominic,

This patch is pretty similar to the one for gallery.  There are some differences because videos can have titles. I display the title or the basename of the file in the banner after saving rather than the full filename like the Gallery app does.  (I'm not sure which one is correct.)

This patch changes the behavior of the open activity so that it no longer returns automatically to the caller when the video is done playing. I'm guessing that was probably a bug that it did that anyway.

Comment 3

[Dietrich Ayala (:dietrich)]

Blocks a blocker.

Comment 4

[Dominic Kuo [:dkuo]]

Comment on attachment 747193 [details]
link to patch on github

David,

This patch looks good, with the patch I am able to save a video while opening it with save option. There is only on minor issue, which is the banner always shows the same filename but the actual saved filename, I am not sure it's your intent or a bug, but gallery shows the actual saved filename so that's why I mention this.

Comment 5

[David Flanagan [:djf]]

Dominic,

Thanks for the review. The filename thing was intentional. I've realized that I don't know what the right behavior is here.  Since UX wants us to say "saved to Gallery" and "Saved to Video" that implies to me that the actual filename and directory should not be displayed to the user.  So I think maybe I got it wrong in the gallery patch.

I'm going to land it as is, and then request UX clarification, and open a new bug to make all three apps consistent on this point.

Comment 6

[David Flanagan [:djf]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/f02b2b29fbffe38f9a05fc53b16dc97049a9d55d

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 f02b2b29fbffe38f9a05fc53b16dc97049a9d55d
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 8

[David Flanagan [:djf]]

Uplifted to v1-train: https://github.com/mozilla-b2g/gaia/commit/2b3f8ba3a662247550cb0e16590197be6a6139ab

Comment 9

[Jason Smith [:jsmith]]

Covered via test case in blocker bug.