Closed Bug 869322 Opened 7 years ago Closed 7 years ago

Screen can't read the text in input box

Categories

(Firefox for Android :: Keyboards and IME, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 23

People

(Reporter: daichen314, Assigned: daichen314)

Details

(Keywords: access)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0
Build ID: 20130329030832

Steps to reproduce:

1. enable google talkback
2. open firefox
3. go to google.com
4. input "aaabbbcccddd" into input box


Actual results:

nothing happened


Expected results:

talkback should read "aaabbbcccddd" after input the text

I download the nightly builds, and I found this version "http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2013/03/2013-03-16-03-08-54-mozilla-central-android/fennec-22.0a1.multi.android-arm.apk" works fine, but this http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2013/03/2013-03-16-16-05-54-mozilla-central-android/fennec-22.0a1.multi.android-arm.apk" works bad
OS: Linux → Android
Hardware: x86_64 → ARM
cc'ing a couple accessibility team members
Keywords: access
I think it is due to bug833164
I update the code to revision 124928, it act properly.
But in revision 124929, it cant read
124929:a4e388a97ff3
124928:80be1feda16c
This bug is because:
after Bug 833164, accessible events cpp were replaced by code gen of xpcom.
The original textchange event had a funtion isInserted, but in the gen code, isInserted changed to a bool attribute.
In Eventmanager, it still calls isInserted(), so it throw a error
Attachment #746832 - Flags: review?
Attachment #746832 - Attachment is patch: true
Attachment #746832 - Flags: review? → review?(eitan)
Assignee: nobody → daichen314
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 746832 [details] [diff] [review]
patch for bug869322

Review of attachment 746832 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch! I'm assuming you tested this?
Attachment #746832 - Flags: review?(eitan) → review+
yes, I have tested it.
What should I do next?
add 'checking-needed' keyword to get the patch landed and find another bug ;)
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad46747e8ec4

Thanks for the patch! In the next day or so, this patch will be merged on to mozilla-central and will be resolved FIXED at that time. Currently, this fix will appear first in Firefox 23. Eitan, should this be nominated for uplift? Seems like a bad bug with a low-risk fix.

One more request, to make life easier for those checking in on your behalf, please make sure that you have Mercurial configured to generate all the necessary metadata for checkin. Instructions are linked below. Thanks again!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ad46747e8ec4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.