869345 - "mach help" shouldn't throw a keyerror exception if you pass it an unknown topic

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[:Gijs (he/him)]

Trying to figure out how to run jetpack tests with mach, I ran:

"mach help jetpack"

as a first guess. That made mach sad, and it went all:

KeyError: 'jetpack'

  File "c:\dev\jamun\python/mach\mach\main.py", line 214, in run
    return self._run(argv)
  File "c:\dev\jamun\python/mach\mach\main.py", line 260, in _run
    handler = Registrar.command_handlers[args.subcommand]

on me.

It shouldn't do that. :-)

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Something like this? :-)

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 746281 [details] [diff] [review]
Patch

This bug may have been fixed by the landing of bug 856392. In either case, I'm 95% confident you got bit rot by it.

Comment 3

[:Gijs (he/him)]

(In reply to Gregory Szorc [:gps] from comment #2)
> Comment on attachment 746281 [details] [diff] [review]
> Patch
> 
> This bug may have been fixed by the landing of bug 856392. In either case,
> I'm 95% confident you got bit rot by it.

Fixed, complete with clippy and all. Nice work, thanks! :-)