869488 - create value_of_css_property command on HTMLElement

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

This will allow us to easily debug is_displayed issues and is part of the WebDriver API so we need to do it eventually

Comment 1

[Jonathan Griffin (:jgriffin)]

+1.  I was just thinking the same thing.

Comment 2

[David Burns :automatedtester]

try desktop - https://tbpl.mozilla.org/?tree=Try&rev=c144d44146c4
try mobile - https://tbpl.mozilla.org/?tree=Try&rev=df2a6e47b452

Comment 3

[David Burns :automatedtester]

mobile is green but desktop is red due to pulling down a bustage

submitting both just in case again with a new parent

Comment 4

[David Burns :automatedtester]

Desktop - https://tbpl.mozilla.org/?tree=Try&rev=e65c82b0846c
Mobile - https://tbpl.mozilla.org/?tree=Try&rev=848e77a64d15

Comment 5

[David Burns :automatedtester]

Attachment: value_of_css_property method

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 747424 [details]
value_of_css_property method

Looks like this patch is missing the test_rendered_element.py file. Will r? after I check the test:)

Comment 7

[David Burns :automatedtester]

Attachment: value_of_css_property method

Comment 8

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 747440 [details]
value_of_css_property method

Why are we using APL instead of MPL for the test?

This patch was uploaded without the 'patch' option ticked, so I can't do inline comments, but:

   /**
+   *
+   *
+   *
+   */
+  getElementValueOfCssProperty: function MDA_getElementValueOfCssProperty(aRequest){
+    let command_id = this.command_id = this.getCommandId();
+    this.sendAsync("getElementValueOfCssProperty",
+                   {element: aRequest.element, propertyName: aRequest.propertyName},
+                   command_id); 

Why all the empty comment lines? They were filled out with some nice documentation in the last patch...

Comment 9

[David Burns :automatedtester]

Attachment: value_of_css_property method

I have checked its all there now... sorry for before

Comment 10

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 747468 [details] [diff] [review]
value_of_css_property method

Review of attachment 747468 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 11

[David Burns :automatedtester]

landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/b2f6d207d6aa

Comment 12

[David Burns :automatedtester]

Checking needed for uplift to B2G branches a=test-only

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/a1f18d8e0a31
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/ce778c235de9

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/b2f6d207d6aa