869538 - fix regression with l10n_merge and utf8

Status: VERIFIED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

when running l10n_merge, we hit this bug:

 ./manage.py l10n_merge fr
/mozilla/vendor/src/funfactory/funfactory/manage.py:47: UserWarning: You're using an old-style Playdoh layout with a top level __init__.py and apps directories. This is error prone and fights the Zen of Python. See http://playdoh.readthedocs.org/en/latest/upgrading.html.
warnings.warn("You're using an old-style Playdoh layout with a top "
Merging into fr...
Traceback (most recent call last):
File "./manage.py", line 28, in <module>
manage.main()
File "/mozilla/vendor/src/funfactory/funfactory/manage.py", line 139, in main
execute_manager(current_settings)
File "/mozilla/vendor-local/src/django/django/core/management/__init__.py", line 438, in execute_manager
utility.execute()
File "/mozilla/vendor-local/src/django/django/core/management/__init__.py", line 379, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/mozilla/vendor-local/src/django/django/core/management/base.py", line 191, in run_from_argv
self.execute(*args, **options.__dict__)
File "/mozilla/vendor-local/src/django/django/core/management/base.py", line 220, in execute
output = self.handle(*args, **options)
File "/mozilla/lib/l10n_utils/management/commands/l10n_merge.py", line 24, in handle
merge_lang_files(langs)
File "/mozilla/lib/l10n_utils/gettext.py", line 261, in merge_lang_files
_append_to_lang_file(dest, new_msgs)
File "/mozilla/lib/l10n_utils/gettext.py", line 267, in _append_to_lang_file
out.write('\n\n;{msg}\n{msg}\n'.format(msg=msg))
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 3: ordinal not in range(128)

I have a patch that works locally, PR coming

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/1589f92b184cf4fbbfef1fd19417f5bf466d5796
Fix bug 869538: append to lang files with unicode strings