Closed
Bug 869539
Opened 12 years ago
Closed 12 years ago
Tidy up Assembler-x64.h's Operand class
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: sunfish, Unassigned)
Details
Attachments
(1 file)
|
2.01 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
The order of the fields in the Operand class in Assembler-x64.h takes up extra padding since the bitfields are separated. Also some methods are missing const.
|
Reporter | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 746498 [details] [diff] [review]
a patch containing a proposed fix
Review of attachment 746498 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #746498 -
Flags: review+
|
|
||
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•