Closed Bug 869634 Opened 7 years ago Closed 7 years ago

Update empty favicon style

Categories

(Firefox for Android :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 23

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

In bug 839855, we updated the small favicon background to have a thin border to create a colored border when the color filter is applied. Right now, we just use that background without a color filter for empty favicons, but we should use a different background image for that case.

There's a mockup here:
https://bug837392.bugzilla.mozilla.org/attachment.cgi?id=739753
Ian, is there a specific image you want to use for the empty favicon? In that mockup, it looks like it's transparent with some border. What color would you want for the border?
Flags: needinfo?(ibarlow)
Assignee: nobody → margaret.leibovic
as discussed in IRC, here are the default globe icons, sized to the same dimensions as the old empty favicon dotted squares. http://cl.ly/2g3r1f3p2T2t
Flags: needinfo?(ibarlow)
Attached patch patchSplinter Review
Updated the favicon.png images in the tree, which automatically updates the default favicon image used in the toolbar.

I updated FaviconView to use this default favicon instead of the blank background for the no-favicon case, and I did a little cleanup that we didn't catch when renaming updateImage from setImageBitmap.
Attachment #747083 - Flags: review?(bnicholson)
Attachment #747083 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/838eaf273334
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.