869634 - Update empty favicon style

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

In bug 839855, we updated the small favicon background to have a thin border to create a colored border when the color filter is applied. Right now, we just use that background without a color filter for empty favicons, but we should use a different background image for that case.

There's a mockup here:
https://bug837392.bugzilla.mozilla.org/attachment.cgi?id=739753

Comment 1

[:Margaret Leibovic]

Ian, is there a specific image you want to use for the empty favicon? In that mockup, it looks like it's transparent with some border. What color would you want for the border?

Comment 2

[Ian Barlow (:ibarlow)]

as discussed in IRC, here are the default globe icons, sized to the same dimensions as the old empty favicon dotted squares. http://cl.ly/2g3r1f3p2T2t

Comment 3

[:Margaret Leibovic]

Attachment: patch

Updated the favicon.png images in the tree, which automatically updates the default favicon image used in the toolbar.

I updated FaviconView to use this default favicon instead of the blank background for the no-favicon case, and I did a little cleanup that we didn't catch when renaming updateImage from setImageBitmap.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/838eaf273334

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/838eaf273334