869673 - Hide the favicon in the toolbar when there's no favicon

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

Instead of showing a default favicon in the toolbar, we should just hide the image view. Tapping on the favicon doesn't do anything, so showing a default favicon is not as useful as having more room to show the title/url.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Did we kill larry?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Did we kill larry?

It seems we did. Was that intentional?

Comment 3

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> (In reply to Mark Finkle (:mfinkle) from comment #1)
> > Did we kill larry?
> 
> It seems we did. Was that intentional?

I still see him if I tap on the lock icon (he's only there on ssl/ev sites).

Comment 4

[Richard Newman [:rnewman]]

Margaret (and Ian!), is this still relevant? Seems like something we'd have tackled by now if we wanted to do it.

Comment 5

[Ian Barlow (:ibarlow)]

I'm torn. On the one hand, I agree this would clean things up. It would probably help about:home as well -- it makes me crazy that we put an icon in the url bar on that page, since that was never the intended design. 

On the other hand, I could see this adding a fair bit of complexity to our title bar favicon/lock animation rules. Probably to the point where this change would not be worth it.

I think the about:home thing bothers me more than when we show a generic favicon on websites. If we could fix the former, I would be ok with leaving the latter as is.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.