869692 - [B2G][inari] OS crashes when making or receiving a call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Natalya Kot [:nkot]]

Attachment: logcat

Description:
OS crash occurs when making a call or during active connected call, does not reproduce 100% but happens quite often

Crash ID:1367963316

Repro Steps:
1) Updated to Inari Build ID: 20130507070205
2) Open Dialer app
3) Make a call from device

Actual:
Device crashes when making a call

Expected:
Able to make a call successfully

Environmental  Variables:
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/7e9e10889942
Gaia: 29f5faf992aa2bacf6a9d500494093edd9472c69
Version 18.0
COM_RIL

Notes:
Repro frequency: 2/2 devices, 50%
See attached logcat for more info

Comment 1

[Marcia Knous [:marcia]]

I can reproduce this using the same build, Ikura/Commercial RIL/, but when receiving a call. I can repro it 1/2 times;

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/7e9e10889942
Gaia   29f5faf992aa2bacf6a9d500494093edd9472c69
BuildID 20130507070205
Version 18.0

Here is my crash report:  https://crash-stats.mozilla.com/report/index/1a76f6c7-f3f0-4706-ab86-93a9e2130507. I have another one queued up but it is in pending.

Comment 2

[Marcia Knous [:marcia]]

Crashes using the Mozilla RIL as well:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/7e9e10889942
Gaia   29f5faf992aa2bacf6a9d500494093edd9472c69
BuildID 20130507070205
Version 18.0

https://crash-stats.mozilla.com/report/index/bd0d5cd4-14fd-4c5e-adea-1b6a52130508

Comment 3

[Jason Smith [:jsmith]]

Gina - Any ideas? Do you have an idea what bug might have caused the regression here?

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

I'll take a look at this and update information later. Thanks for reporting.

Comment 5

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: Using IsConnected() at the beginning of HandleCallStateChanged()

I made a v1.0.1-specific patch for bug 860166, however I forgot to replace original conditional check at the beginning of HandleCallStateChanged() with IsConnected(). That's the root cause of the crash.

Comment 6

[Eric Chou [:ericchou] [:echou]]

Forgot to mention that the crash is caused by using a null mSocket, and IsConnected() would check if mSocket has value.

This bug is v1.0.1 only.

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 746800 [details] [diff] [review]
patch 1: Using IsConnected() at the beginning of HandleCallStateChanged()

Review of attachment 746800 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!

Comment 8

[Eric Chou [:ericchou] [:echou]]

Hi sheriff,

Please note that this is a v1.0.1-only bug. Thank you.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Needs tef+ before I can push (sorry).

Comment 10

[Jason Smith [:jsmith]]

Now it's got tef+. Thanks Andreas. Can we land this?

Comment 11

[Nick Davidson]

Issue repro on Inari v1.0.1 Comm
Build ID: 20130508070205
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/c3a5041bfe5a
Gaia: 89a9c5de7313dfd1095d0ff46988bc91a35cbe9c

and Inari v1.0.1 Mozilla
Build ID: 20130508070205
Gecko: c3a5041bfe5a
Gaia: 89a9c5de7313dfd1095d0ff46988bc91a35cbe9c

When receiving call device crashes and reboots immediately without ringing.

When Calling from a device device crashes, reboots but stays on active call without loosing it.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/399561ce629a

Comment 13

[Chris Kreinbring [:CKreinbring]]

Verified fixed on Inari 1.0.1 commercial RIL.  User is able to make calls without the OS crashing.

Build ID: 20130508104236
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/af99cb91eec0
Gaia: 89a9c5de7313dfd1095d0ff46988bc91a35cbe9c