Closed
Bug 869730
Opened 7 years ago
Closed 7 years ago
Fix an opt build error with ggc enabled
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Not set
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.11 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
I missed that JSRuntime::gcDisableStrictProxyCheckingCount is DEBUG only.
Attachment #746691 -
Flags: review?(wmccloskey)
Sorry, this is my fault. I changed it recently and didn't change the nursery. I think a better way, if it works, would be to add an AutoDisableProxyCheck field to the MinorCollectionTracer.
|
Assignee | |
Comment 2•7 years ago
|
||
Thank you, this is much nicer. I also added guard object macros to the guard object, just because.
Attachment #746691 -
Attachment is obsolete: true
Attachment #746691 -
Flags: review?(wmccloskey)
Attachment #747706 -
Flags: review?(wmccloskey)
Attachment #747706 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Green try at: https://tbpl.mozilla.org/?tree=Try&rev=ab2edeb50f5f Pushed at: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1a91eac6358
|
||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c1a91eac6358
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•