Closed Bug 869745 Opened 11 years ago Closed 6 years ago

[Buri][IOT]The STK app is not available in the main menu

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:-)

RESOLVED WONTFIX
blocking-b2g -

People

(Reporter: sync-1, Unassigned, NeedInfo)

References

Details

(Whiteboard: Chile, IOT, buri)

Attachments

(3 files, 3 obsolete files)

AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.019.092
 Firefox os  v1.0.1
 Mozilla build ID:20130430070201
 
 
 +++ This bug was initially created as a clone of Bug #450203 +++
 
 DEFECT DESCRIPTION:
 The STK app is not available in the main menu. Is only available into the "settings" menu
 
  REPRODUCING PROCEDURES:
 1.- Insert SIM Card and turn the DuT On
 2.- Verify that the STK app is not available in the main menu
 
 
  EXPECTED BEHAVIOUR:
 The STK icon and label should be displayed in the main menu correctly.
 When selecting the movistar icon the label should be the word “movistar"
 
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 High
 
  REPRODUCING RATE:
 100%
 
  For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #450203 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
  DEFECT DESCRIPTION:
 
  REPRODUCING PROCEDURES:
 
  EXPECTED BEHAVIOUR:
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:
blocking-b2g: --- → tef?
triage: tef-. per tef, It is ok to be in the settings as designed.
blocking-b2g: tef? → -
Whiteboard: Chile, IOT, buri
Component: Vendcom → Gaia::Settings
Blocks: 911060
No longer blocks: 911060
Fernando, we would like to know if it is possible to add an icon (an access) in the homescreen so we can make easy the access to this service widely use in many of the launched markets.
Flags: needinfo?(frsela)
See Also: → 1016807
(In reply to Beatriz Rodríguez [:brg] from comment #4)
> Fernando, we would like to know if it is possible to add an icon (an access)
> in the homescreen so we can make easy the access to this service widely use
> in many of the launched markets.

Hi,

Yes, it's possible. We can add a little independent app which acts as a launcher.

This app will open settings into the ICC page (with little changes in settings app)
Flags: needinfo?(frsela)
Assignee: nobody → frsela
Comment on attachment 8468256 [details] [review]
Webapp to open settings in the ICC page

Flagging UI review.

We need a better icon for the new app ;)
Attachment #8468256 - Flags: ui-review?(firefoxos-ux-bugzilla)
Comment on attachment 8468256 [details] [review]
Webapp to open settings in the ICC page

Hi Vivien,

This app is a proposal to solve this bug. The idea is to show an Icon in the Homescreen that opens the STK menu in settings.

Currently I'm using mozSettings (as we did in the past to pass the STK messages between System and Settings) but I'm considering to use the new IAC API [1].

What do you think?

[1] https://wiki.mozilla.org/WebAPI/Inter_App_Communication
Attachment #8468256 - Flags: feedback?(sync-1) → feedback?(21)
Comment on attachment 8468256 [details] [review]
Webapp to open settings in the ICC page

Can't we just create a dedicated STK app that contains everything needed and stop playing around with settings/system ?
Attachment #8468256 - Flags: feedback?(21)
A few questions on ui-review:

* Is this only for Developer mode? Most users have no idea what "STK" means or what it is for, so we may not want an end-user-facing app to have this name.

* I'm also flagging Peter and Candice on the Sys FE team, to ensure they're aware of a proposed addition to the homescreen. I'm flagging Francis on the ui-review not just for the icon, but of the concept and homescreen addition.
Flags: needinfo?(pdolanjski)
Flags: needinfo?(cserran)
Comment on attachment 8468256 [details] [review]
Webapp to open settings in the ICC page

Flagging Francis on ui-review of this idea.
Attachment #8468256 - Flags: ui-review?(firefoxos-ux-bugzilla) → ui-review?(fdjabri)
(In reply to Stephany Wilkes from comment #10)
> A few questions on ui-review:
> 
> * Is this only for Developer mode? Most users have no idea what "STK" means
> or what it is for, so we may not want an end-user-facing app to have this
> name.
> 

Hi Stephany,

No, this menu is for the end-user anywaky, STK is the tech. name, it's also known as "Operator menu"

This is used by mobile operators to offer additional services to their clients.

Regards.
(In reply to (PTO) Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #9)
> Comment on attachment 8468256 [details] [review]
> Webapp to open settings in the ICC page
> 
> Can't we just create a dedicated STK app that contains everything needed and
> stop playing around with settings/system ?

Hi Vivien,

This is a recursive discussion :D [1]

The decission to implement STK inside settings menu was not technical. I think UX decided that at the begining of the project.

Technically, Settings part can be moved to an independent app.

Anyway, I think the System part is needed to avoid opening/closing apps for each STK message (we splitted the code between System and Settings to avoid opening Settings for each STK System Message)
Also, many STK messages needs to register some events [2] and the app shouldn't be closed.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=875679
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/icc_events.js
Would this be part of the default build, or would this just be included as a preload for specific markets?
Flags: needinfo?(pdolanjski) → needinfo?(frsela)
Hi Fernando, I'm afraid that you're going to have to help me with this review. I flashed your patch with the following commands:

git remote add frsela https://github.com/frsela/gaia.git
git fetch frsela
git checkout frsela/STK/Bug869745
make install-gaia

but after flashing the device I couldn't find a new icon. 

In any case, judging by your description, if tapping on the icon deep-links the user into the settings app, then it seems to make more sense from a UX perspective to access these settings from within the settings app. 

If however tapping on the app icon takes the user to more app-like experiences, then I could see how an icon could be justified.
Flags: needinfo?(cserran)
QA Contact: lolimartinezcr
QA Contact: lolimartinezcr
(In reply to Francis Djabri [:djabber] from comment #15)
> Hi Fernando, I'm afraid that you're going to have to help me with this
> review. I flashed your patch with the following commands:
> 
> git remote add frsela https://github.com/frsela/gaia.git
> git fetch frsela
> git checkout frsela/STK/Bug869745
> make install-gaia
> 
> but after flashing the device I couldn't find a new icon. 
> 

It should be desplayed into the third section of the vertical homescreen (after the Usage app)
Try using make reset-gaia

or by calling this script:

https://github.com/AntonioMA/gaiatools/blob/master/resetApps.sh

> In any case, judging by your description, if tapping on the icon deep-links
> the user into the settings app, then it seems to make more sense from a UX
> perspective to access these settings from within the settings app. 
> 

Do you mean implement all the STK menu inside the external App?

> If however tapping on the app icon takes the user to more app-like
> experiences, then I could see how an icon could be justified.

Not sure if I understood you. But this is only a launcher required by some carriers in the certification process
Flags: needinfo?(frsela)
(In reply to [PTO from 18 to 21 Aug] Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #16)
> (In reply to Francis Djabri [:djabber] from comment #15)
> > Hi Fernando, I'm afraid that you're going to have to help me with this
> > review. I flashed your patch with the following commands:
> > 
> > git remote add frsela https://github.com/frsela/gaia.git
> > git fetch frsela
> > git checkout frsela/STK/Bug869745
> > make install-gaia
> > 
> > but after flashing the device I couldn't find a new icon. 
> > 
> 
> It should be desplayed into the third section of the vertical homescreen
> (after the Usage app)
> Try using make reset-gaia
> 
> or by calling this script:
> 
> https://github.com/AntonioMA/gaiatools/blob/master/resetApps.sh

Thanks, using make reset-gaia worked, but once I tapped the icon it seemed to only launch the settings app. 

> 
> > In any case, judging by your description, if tapping on the icon deep-links
> > the user into the settings app, then it seems to make more sense from a UX
> > perspective to access these settings from within the settings app. 
> > 
> 
> Do you mean implement all the STK menu inside the external App?
> 

No, I mean, if tapping the external app icon simply deep links the user into the Settings app, it makes sense to me that the user should access the STK menu from within the settings app, rather than using a separate icon. 

> > If however tapping on the app icon takes the user to more app-like
> > experiences, then I could see how an icon could be justified.
> 
> Not sure if I understood you. But this is only a launcher required by some
> carriers in the certification process

What I meant here was that if the STK menu launches richer apps that appear like other apps that the user can download, then i could see how having an external app icon could be justified.
(In reply to Francis Djabri [:djabber] from comment #17)
> 
> Thanks, using make reset-gaia worked, but once I tapped the icon it seemed
> to only launch the settings app. 
>

Has your SIM card STK support? (Check if the Operator menu is available at the end of the settings list)
 
> 
> No, I mean, if tapping the external app icon simply deep links the user into
> the Settings app, it makes sense to me that the user should access the STK
> menu from within the settings app, rather than using a separate icon. 
> 

If settings app is opened, it'll surf to the STK menu, if it's closed it will open settings and after that open STK menu

> What I meant here was that if the STK menu launches richer apps that appear
> like other apps that the user can download, then i could see how having an
> external app icon could be justified.

Oh, I agree, but some carriers asked for the launcher in the Main menu
> > What I meant here was that if the STK menu launches richer apps that appear
> > like other apps that the user can download, then i could see how having an
> > external app icon could be justified.
> 
> Oh, I agree, but some carriers asked for the launcher in the Main menu

In that case I'd just repeat Peter's question in comment #14 :)
(In reply to Francis Djabri [:djabber] from comment #19)
> In that case I'd just repeat Peter's question in comment #14 :)

NI to Bea, but she's in PTO till 25th Aug.
Flags: needinfo?(beatriz.rodriguezgomez)
Hi Peter, I'm not sure if you're the right person to ask, but we need a new home screen icon for the SIM app toolkit app. It seems to be a hard operator requirement to have this in the main menu, but we're checking to see if it can be switched off in certain markets.
Flags: needinfo?(pla)
Hi Francis,

Yes I'm the right person to ask. :)  I can provide this.  Stephany or Peter D - can you let me know what is the urgency/deadline for this icon?

THanks!
Flags: needinfo?(swilkes)
Flags: needinfo?(pla)
Flags: needinfo?(pdolanjski)
It's sprint 3 so ASAP please. Sorry! Trying to get all 2.1 items landed this week.
Flags: needinfo?(swilkes)
I really don't think we should include this as part of the default build. (as it is not relevant in some markets)  Would there be an issue with the operator/oem preloading it instead? (or are there some permissions implications)
Flags: needinfo?(pdolanjski) → needinfo?(frsela)
UX agrees, Peter.
Hi,

Attached is the SIM Toolkit icon in 5 sizes.

Cheers,
Peter
Attachment #8468256 - Flags: ui-review?(fdjabri)
Flags: needinfo?(frsela)
Icons updated in the PR. Thank you Peter !
(In reply to Peter Dolanjski [:pdol] from comment #24)
> I really don't think we should include this as part of the default build.
> (as it is not relevant in some markets)  Would there be an issue with the
> operator/oem preloading it instead? (or are there some permissions
> implications)

Not sure if this should be included in master or will be preloaded.
Probably Beatriz can answer this question better than me ;)
Yes, agree, we do not need this in default builds. 
Lets leave it as a third party app that OEM can take to include in their builds if they consider it interesting.
Please add a warning message to the user when no SIM card is inserted.
Flags: needinfo?(beatriz.rodriguezgomez)
Patch rebased & updated.

Now it uses IAC instead mozSettings hacks ;)
Also it shows an alert if no STK Menu is available before close the app.
QA Contact: lolimartinezcr
This patch allows external apps to open settings into the STK page (if available)

This code should be used:

var activity = new MozActivity({
 name : 'configure',
 data : {
  target : 'device',
  section: 'icc'
 }
});
Attachment #8468256 - Attachment is obsolete: true
Attachment #8487909 - Flags: review?(21)
Comment on attachment 8487915 [details] [diff] [review]
STK Launcher app for developer builds

Only for feedback; I'll upload a L10N version soon
Attachment #8487915 - Flags: review?(21) → feedback?(21)
L10N added
Attachment #8487915 - Attachment is obsolete: true
Attachment #8487915 - Flags: feedback?(21)
Attachment #8487967 - Flags: review?(21)
Comment on attachment 8487909 [details] [review]
Settings support to open STK panel through "configure" activity

Not really STK specific, so let's ask a review to Arthur.
Attachment #8487909 - Flags: review?(21) → review?(arthur.chen)
Comment on attachment 8487967 [details] [diff] [review]
STK Launcher app for developer builds

Review of attachment 8487967 [details] [diff] [review]:
-----------------------------------------------------------------

Let's not block on the shared/ lib since this is a dev_apps. So r+ with nits.

::: dev_apps/stklauncher/index.html
@@ +3,5 @@
> +  <head>
> +    <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1">
> +    <meta charset="utf-8">
> +    <meta name="theme-color" content="#00adad">
> +    <title data-l10n-id="app_name">StK LaUnChEr</title>

The app name is awful :)

::: dev_apps/stklauncher/js/launch_stk.js
@@ +33,5 @@
> +    }
> +  };
> +  reqApplications.onerror = function icc_getApplicationsError() {
> +    callback(false);
> +  };

Looking at the code and the other code in the settings app for the other patch. I do wonder if we want to make a shared/js/ lib to retrieve the list of STK apps ? What do you think ?

::: dev_apps/stklauncher/locales/locales.ini
@@ +1,4 @@
> +@import url(stklauncher.en-US.properties)
> +
> +[es]
> +@import url(stklauncher.es-ES.properties)

Pretty sure the l10n team wants to remove additional locales by default. Let's remove it here too.

::: dev_apps/stklauncher/locales/stklauncher.es-ES.properties
@@ +1,2 @@
> +app_name            = Lanzador STK
> +stk_not_available   = STK no disponible
\ No newline at end of file

Let's remove this file.

::: dev_apps/stklauncher/manifest.webapp
@@ +7,5 @@
> +    "name": "The Gaia Team",
> +    "url": "https://github.com/mozilla-b2g/gaia"
> +  },
> +  "permissions": {
> +    "webapps-manage":{},

Do we need this permission ?
Attachment #8487967 - Flags: review?(21) → review+
Thank you Vivien.

(In reply to Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) from comment #36)
> Comment on attachment 8487967 [details] [diff] [review]
> > +    <title data-l10n-id="app_name">StK LaUnChEr</title>
> 
> The app name is awful :)
> 

Changed. I wrote that way for l10n testing ;)

> Pretty sure the l10n team wants to remove additional locales by default.
> Let's remove it here too.

Dropped spanish translations

> > +  "permissions": {
> > +    "webapps-manage":{},
> 
> Do we need this permission ?

Agree, not needed, I forgot to remove it when I changed the way for opening settings app. Thanks
Attachment #8487967 - Attachment is obsolete: true
Attachment #8491466 - Flags: review+
> 
> Looking at the code and the other code in the settings app for the other
> patch. I do wonder if we want to make a shared/js/ lib to retrieve the list
> of STK apps ? What do you think ?
> 

Agree.

Also, now we've better ways to do it: Instead store the list of STK apps in mozSettings, I suggest we should use DataStores. WDYT?

I suggest to drive it in another bug since it implies changes in System, Settings, Shared, ...
Flags: needinfo?(21)
The requirement sound like a standalone STK app. Is there anything prevents us from moving toward the direction?
Flags: needinfo?(frsela)
Just saw comment 13 and it seems the current UX design. Flagging Jenny for her inputs.
Flags: needinfo?(frsela) → needinfo?(jelee)
Hello, since STK is essentially service provided by operator, and does not necessarily contain setting related to device or settings that might affect other apps, I think we can consider making STK a standalone app and remove it from Settings.

What do you think Francis :) ?
Flags: needinfo?(jelee) → needinfo?(fdjabri)
(In reply to Jenny Lee from comment #41)
> Hello, since STK is essentially service provided by operator, and does not
> necessarily contain setting related to device or settings that might affect
> other apps, I think we can consider making STK a standalone app and remove
> it from Settings.
> 
> What do you think Francis :) ?

That seems fine to me. As discussed above, my one concern was that the app should not be included on the default build as it's not relevant to some markets, but that seems to have been addressed by Bea in comment 29.
Flags: needinfo?(fdjabri)
Comment on attachment 8487909 [details] [review]
Settings support to open STK panel through "configure" activity

Clearing the review request first as STK is going to be a standalone app per the previous comments.
Attachment #8487909 - Flags: review?(arthur.chen)
I not sure if it feasible at this moment to remove STK from settings, so asking Fernando...
Flags: needinfo?(frsela)
(In reply to Marcelino Veiga Tuimil [:sonmarce] from comment #44)
> I not sure if it feasible at this moment to remove STK from settings, so
> asking Fernando...

As discussed some time ago, this is not "trivial" change and requires a strong effort to assure all STK certification process is passed again.

The STK System part is harder to change to standalone app since we need to register this app to some events in order to inform the card about them which requires the app to be opened all the time.
We moved from settings to system because the UX dirty effects (moving windows in each STK command) when we had all STK inside settings.

So we should study the pros and cons carefully. Also the needed effort to make this big change.

From our part, we don't have enough resources to address this now.
Flags: needinfo?(frsela)
(In reply to Jenny Lee from comment #41)
> Hello, since STK is essentially service provided by operator, and does not
> necessarily contain setting related to device or settings that might affect
> other apps, I think we can consider making STK a standalone app and remove
> it from Settings.
> 
> What do you think Francis :) ?
When do you plan to do it? please read comment #45 to understand the big impact.

In the meantime, could you please evaluate our proposal as an easy solution for now?

Our goal(for any OEM interested) is to have an easy way to make this service more easy to accesss by end users while keeping it working as expected and no issues in GCF and certification process.
Flags: needinfo?(jelee)
(In reply to Beatriz Rodríguez [:brg] from comment #46)
> (In reply to Jenny Lee from comment #41)
> > Hello, since STK is essentially service provided by operator, and does not
> > necessarily contain setting related to device or settings that might affect
> > other apps, I think we can consider making STK a standalone app and remove
> > it from Settings.
> > 
> > What do you think Francis :) ?
> When do you plan to do it? please read comment #45 to understand the big
> impact.
> 
> In the meantime, could you please evaluate our proposal as an easy solution
> for now?
> 
> Our goal(for any OEM interested) is to have an easy way to make this service
> more easy to accesss by end users while keeping it working as expected and
> no issues in GCF and certification process.

Making STK a standalone app and removing it from Settings will most likely happen in 2.2 (still under planning). I understand your resource limitation and I'm open to your proposal as a temporary fix during the transition phase. Thanks!
Flags: needinfo?(jelee)
Assignee: frsela → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: