Closed
Bug 869784
Opened 12 years ago
Closed 12 years ago
Fix rooting hazards in the profiler
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.30 KB,
patch
|
BenWa
:
review+
till
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #746750 -
Flags: review?(tschneidereit)
Attachment #746750 -
Flags: review?(bgirard)
|
Assignee | |
Comment 1•12 years ago
|
||
Oops, that wouldn't build!
Assignee: nobody → ehsan
Attachment #746750 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #746750 -
Flags: review?(tschneidereit)
Attachment #746750 -
Flags: review?(bgirard)
Attachment #746751 -
Flags: review?(tschneidereit)
Attachment #746751 -
Flags: review?(bgirard)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 746751 [details] [diff] [review]
Patch (v1)
Review of attachment 746751 [details] [diff] [review]:
-----------------------------------------------------------------
::: tools/profiler/JSObjectBuilder.cpp
@@ +6,5 @@
> #include "jsapi.h"
> #include "nsStringGlue.h"
> #include "JSObjectBuilder.h"
>
> +JSObjectBuilder::JSObjectBuilder(JSContext *aCx) : mCx(aCx), mObj(aCx), mOk(JS_TRUE)
Why not just remove mCx? The rest looks fine.
Attachment #746751 -
Flags: review?(bgirard) → review+
|
||
Comment 3•12 years ago
|
||
Comment on attachment 746751 [details] [diff] [review]
Patch (v1)
Review of attachment 746751 [details] [diff] [review]:
-----------------------------------------------------------------
What BenWa said.
Attachment #746751 -
Flags: review?(tschneidereit) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
(In reply to Benoit Girard (:BenWa) from comment #2)
> Comment on attachment 746751 [details] [diff] [review]
> Patch (v1)
>
> Review of attachment 746751 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: tools/profiler/JSObjectBuilder.cpp
> @@ +6,5 @@
> > #include "jsapi.h"
> > #include "nsStringGlue.h"
> > #include "JSObjectBuilder.h"
> >
> > +JSObjectBuilder::JSObjectBuilder(JSContext *aCx) : mCx(aCx), mObj(aCx), mOk(JS_TRUE)
>
> Why not just remove mCx? The rest looks fine.
Remove mCx? Not sure what you mean, mCx is used all over the place.
|
|
Assignee | |
Updated•12 years ago
|
Flags: needinfo?(bgirard)
|
|
||
Comment 5•12 years ago
|
||
Opps mObj*. I couldn't see it used anywhere last night.
Flags: needinfo?(bgirard)
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•