869800 - Remove JS_GetGlobalObject from workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Bobby Holley (:bholley)]

All of this stuff appears to be happening on the worker cx. I can't quite tell whether there are ever multiple globals/compartments involved for a given cx - it seems like there might be with sub-workers, but I can't quite tell.

Either way though, it seems like all of these would be better off just pulling the global off the current compartment rather than grabbing the default one stashed on the context, especially the aforementioned API is going away.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=1a99fbc1dd5d

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

There are no shared globals/compartments/contexts at all. If we are running with a worker cx then its global object can only be the worker associated with that cx.

Comment 3

[Bobby Holley (:bholley)]

(In reply to ben turner [:bent] from comment #2)
> There are no shared globals/compartments/contexts at all. If we are running
> with a worker cx then its global object can only be the worker associated
> with that cx.

In that case, these patches should be totally fine (they pass mochitests, anyway). I'll upload now.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 1 - Remove JS_GetGlobalObject from workers. v1

Comment 5

[Bobby Holley (:bholley)]

Attachment: Part 2 - Stop using calling JS_SetGlobalObject in workers. v1

This makes workers the first consumer to be weaned off this API. \o/

Comment 6

[Bobby Holley (:bholley)]

This is green.

Comment 7

[Bobby Holley (:bholley)]

Thanks for the review ben - I know you're busy. :-)

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/cbebcd9f2531
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/469e647ccbf5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cbebcd9f2531
https://hg.mozilla.org/mozilla-central/rev/469e647ccbf5