869805 - Improve orbit throbber

Status: RESOLVED INCOMPLETE

(Firefox for Metro Graveyard :: Theme, defect)

Description

[Frank Yan (:fryn)]

Attachment: patch

I'd like to make throbber that we landed in bug 852622 smoother and match some important details of the native throbber; for example, the leading circle should catch up with the tail circle on the second revolution.

The CSS could also use some cleanup.
http://cssload.net/ does not output valid CSS. :/

I used the following Microsoft "spinner" as a reference:
https://secure.wlxrs.com/$live.controls.images//common/spinner_grey_40_transparent.gif

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Comment on attachment 746786 [details] [diff] [review]
patch

Review of attachment 746786 [details] [diff] [review]:
-----------------------------------------------------------------

The CSS looks fine but there are problems with the xul.

::: browser/metro/base/content/bindings/cssthrobber.xml
@@ +13,3 @@
>      <content>
> +      <html:div>
> +        <html:div class="progress-ball-container"><div class="progress-ball"/></div>

You're not closing the html:divs and I don't understand why you need a wrapper around every progress-ball instead of what was there before. It doesn't seem to match your CSS even.

Comment 2

[Frank Yan (:fryn)]

I addressed the review comments locally, but it doesn't seem to render the throbber correctly. I wasn't able to figure out what's wrong with the code. :(