869817 - [Email] "Last Sync:" value at folder screen is not displayed properly with IMAP accounts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Leo]

1. Title : "Last Sync:" value at folder screen is not displayed properly with IMAP accounts
2. Precondition : Email should be working and an IMAP account is configured
3. Tester's Action:  Launch Email -> upon receiving messages -> Go to folder screen.
4. Detailed Symptom (ENG.) : "Last Sync:" is always 7hr ago or empty
5. Expected :Last Sync should be displayed properly.
6.Reproducibility: Y
           1)Frequency Rate : 100%
7.Gaia Master/v1-train : Reproduced
8.Gaia Revision: 3c199e889364a0cc20f1b13a37eb309364a73de9
9.Personal email id:  [e-mail]

Comment 1

[psingapati]

Attachment: Last Sync Always 7hrs Ago

Attachment always shows last sync 7hrs ago. 
I believe the folder.lastSyncedAt is coming as NULL from the gelam.
Please check

Comment 2

[psingapati]

Attachment: Emails List not shown properly

One more issue observed related to time stamp,
The attached image contains mails shows in wrong order.

Please check

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

(In reply to psingapati from comment #2)
> Created attachment 746887 [details]
> Emails List not shown properly
> 
> One more issue observed related to time stamp,
> The attached image contains mails shows in wrong order.
> 
> Please check

This needs to be a different bug.  Whatever's going on is definitely a different code path.

Comment 4

[psingapati]

Attachment: Pull Request pointer

lastSyncedAt is assigned with NOW() as endTS is used along with TimeZone offset.

Please review it.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 751267 [details]
Pull Request pointer

r=asuth.  Note that this only fixes the time offset problem.

While testing I realized that our problem where we don't set the value at startup is related to a this/self problem in onFoldersSplice inside a forEach.  So only the logic in onFoldersChange works.  Changing 'this' to 'self' in that case corrects the problem.  I'm going to treat that as a required review change and land that with the GELAM change in gaia.

Thanks very much for the fix!

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia-email-libs-and-more/master:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/203
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/26bd3b642b5392c338bcb3872abe0dbc902cbce3

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/9857
https://github.com/mozilla-b2g/gaia/commit/feee2701e8dc5d226331a5ce9682f2b61057b012

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

Uplifted feee2701e8dc5d226331a5ce9682f2b61057b012 to:
v1-train: 78bc92bad902d7c35feb842f04f2498f07f47241

Comment 8

[:CSchmoeckel]

In MozTrap added Email Suite Test Case #9012 - [Email] Verify that the "Last Sync" field is updated and displayed correctly for IMAP email accounts