Closed Bug 869821 Opened 11 years ago Closed 11 years ago

[Bluetooth] Bluetooth device name should not be modified as space.

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:leo+, b2g18 fixed)

RESOLVED FIXED
1.1 QE2 (6jun)
blocking-b2g leo+
Tracking Status
b2g18 --- fixed

People

(Reporter: leo.bugzilla.gecko, Assigned: johnhu)

References

()

Details

(Whiteboard: [TD-23516][good first bug][mentor=evelyn])

Attachments

(2 files)

Dear Mozilla Team,

Currently, bluetooth device name can modify as space bar.
But if this is possible, there is a problem in opp share screen. (please see attached image)
In my opinion, rename block is right when only space inserted.
Please check this point.

Thanks.
Assignee: nobody → ehung
blocking-b2g: --- → leo?
Whiteboard: [TD-23516]
Triage - 4/8 - Leo+ per attached image, it seems to cause a fail to select device.
blocking-b2g: leo? → leo+
Assignee: ehung → nobody
Whiteboard: [TD-23516] → [TD-23516][good first bug][mentor=evelyn]
I believe it's an low-hanging fruit for new comer. I would like to mentor someone to fix it.
Assignee: nobody → johu
Use regexp to remove the left-most and right most white-spaces.
Attachment #747739 - Flags: review?(ehung)
Attachment #747739 - Attachment mime type: text/x-patch → text/html
Comment on attachment 747739 [details]
A pull request for Bug 869821

r=me, good job! Thank you.
Attachment #747739 - Flags: review?(ehung) → review+
Merged into gaia-master
https://github.com/mozilla-b2g/gaia/commit/64c0cd9848c464527d5aaeb9c6ae3d91d98ed317

John, please close this issue and ni jford for uplift. Thanks.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to Evelyn Hung [:evelyn] from comment #5)
> Merged into gaia-master
> https://github.com/mozilla-b2g/gaia/commit/
> 64c0cd9848c464527d5aaeb9c6ae3d91d98ed317
> 
> John, please close this issue and ni jford for uplift. Thanks.

okay, someone told me we should:
1. close the issue as fixed.
2. flag status-b2g18 "affected"
Then :jhford will help on uplift. :)
Target Milestone: --- → 1.1 QE2
John, can you uplift to v1-train please?
Flags: needinfo?(jhford)
[v1-train 19a52cb]
Flags: needinfo?(jhford)
Flags: in-moztrap?
Flags: in-moztrap? → in-moztrap+
Whiteboard: [TD-23516][good first bug][mentor=evelyn] → [TD-23516][good first bug][mentor=evelyn] burirun1
Darren - Please file a new bug for this issue.
Whiteboard: [TD-23516][good first bug][mentor=evelyn] burirun1 → [TD-23516][good first bug][mentor=evelyn]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: