869827 - Crash [@ java.lang.NullPointerException: at org.mozilla.gecko.BrowserApp.onPrepareOptionsMenu(BrowserApp.java) ]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Adrian Tamas (:AdrianT)]

This bug was filed from the Socorro interface and is 
report bp-129a82f2-7480-4439-b289-d5f732130508 .
============================================================= 
Firefox Mobile 21 RC / Nightly 23.0a1 2013-05-07

Steps to reproduce:
1. Add an article to the Reading List
2. Open the Awesomescreen, go to Bookmarks-> Reading List and long tap on the item to open the context menu
3. Choose to edit the reading list entry and in the place of the URL add "news.google.com"
4. Save the changes and attempt to open the reading list

Expected Result:
The url should not be editable

Actual Result:
The url can be changed and when the link is opened the app crashes

Java stack:
java.lang.NullPointerException
	at org.mozilla.gecko.BrowserApp.onPrepareOptionsMenu(BrowserApp.java:1020)
	at org.mozilla.gecko.GeckoApp.invalidateOptionsMenu(GeckoApp.java:422)
	at org.mozilla.gecko.BrowserApp.onTabChanged(BrowserApp.java:122)
	at org.mozilla.gecko.Tabs$6.run(Tabs.java:498)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4895)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:994)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:761)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Aaron Train [:aaronmt]]

Reproduced on my LG Nexus 4 (Android 4.2.2, Nightly 06/08).

Comment 2

[:Margaret Leibovic]

The recent crashes here were from me... I forgot that I had made a bad reading list entry to test this bug :)

We should definitely fix this, but I doubt it's something users would hit often.

Comment 3

[:Margaret Leibovic]

Thinking about how to fix this bug, I think we should just disable the "Edit" menuitem for reading list items. They're not bookmarks that the user created, so I don't know that it makes sense to let them edit them, especially if editing the URL would make it stop working in reader mode.

I think this issue is so rare that we don't need to worry about fixing URLs that users may have broken.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 5

[Richard Newman [:rnewman]]

You can no longer edit reading list items.