869843 - [Settings] Remove the "WPA-EAP" option from "Security" menu of "Join hidden network".

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

WPA-EAP mode is currently disabled, per Bug 790054, so this option has to be removed until WPA-EAP mode is supported.

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: Pull Request

[Approval Request Comment]
Bug caused by (feature/regressing bug #): WPA-EAP currently disabled, Bug 790054, but UI is not fully disabled.
User impact if declined: WPA-EAP functionality is disabled on main Wifi function. Without this patch, user can access the unsupported function. This might get user confused, and the function might not work as expect. 
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): No
String or UUID changes made by this patch: No

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 746899 [details]
Pull Request

Thank you for the patch, Chuck! r=me with the comment in github addressed.

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

(In reply to Arthur Chen [:arthurcc] from comment #2)
> Comment on attachment 746899 [details]
> Pull Request
> 
> Thank you for the patch, Chuck! r=me with the comment in github addressed.

Done! Thank you!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/5d554abd7c5f6963ed12c2d3f0161ea385b7a79a

Comment 5

[Alex Keybl [:akeybl]]

Single line change - let's tef+

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

This bug was partially uplifted.

Uplifted 5d554abd7c5f6963ed12c2d3f0161ea385b7a79a to:
v1-train: d0f00a967e2a30db21d2cb3e831b4cb9dbee8afc

Commit 5d554abd7c5f6963ed12c2d3f0161ea385b7a79a didn't uplift to branch v1.0.1

Comment 7

[Daniel Coloma:dcoloma]

Arthur, can you please ensure your patch lands in 1.0.1?

Comment 8

[Kai-Chih Hu [:khu]]

Talked with Arthur and he will do it now.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.0.1: https://github.com/mozilla-b2g/gaia/commit/86ffb728adaf096ac9b1524477d303ef07924c73

Comment 10

[Cody Roesch [:croesch]]

Inari Build: 20130530070213
Version: 18.0
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/11b55d3ada71
Gaia   ac293ce59acc3bede083fad1b973794fa8bf0253


Leo Build: 20130529070208
Version: 18.0
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/09ac1fd2959c
Gaia   1cca9324d4444ad28c6fa99875e17abf7e8230be

This bug has been verified on both Inari and Leo devices. There is no more option for WPA-EAP in the hidden networks security.