869845 - FirePlatformEvent shouldn't be virtual

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

see http://mxr.mozilla.org/mozilla-central/ident?i=FirePlatformEvent&filter=

Comment 1

[Trevor Saunders (:tbsaunde)]

why can't we just put all that code in HandleAccevent()?

Comment 2

[alexander :surkov (:asurkov)]

it seems ok

Comment 3

[alexander :surkov (:asurkov)]

assigning to Zach per email.

Comment 4

[Zach (:xuku)]

Attachment: Takes FirePlatformEvent() code and makes it inline at the only call site per platform, removes declarations and definitions of the function.

Comment 5

[Trevor Saunders (:tbsaunde)]

Comment on attachment 749908 [details] [diff] [review]
Takes FirePlatformEvent() code and makes it inline at the only call site per platform, removes declarations and definitions of the function.

> AccessibleWrap::HandleAccEvent(AccEvent* aEvent)
> {
>   NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;
> 
>   nsresult rv = Accessible::HandleAccEvent(aEvent);
>   NS_ENSURE_SUCCESS(rv, rv);
> 
>-  return FirePlatformEvent(aEvent);
>-
>-  NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT;
>-}
>-
>-nsresult
>-AccessibleWrap::FirePlatformEvent(AccEvent* aEvent)
>-{
>   NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;

I think you can remove this and then you won't need the second one at the end of the function.

Comment 6

[Zach (:xuku)]

Attachment: Updated with requested changes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c66d8ea1b2f1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c66d8ea1b2f1