Last Comment Bug 869845 - FirePlatformEvent shouldn't be virtual
: FirePlatformEvent shouldn't be virtual
Status: RESOLVED FIXED
[good first bug][mentor=surkov.alexan...
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla24
Assigned To: Zach (:xuku)
:
Mentors:
Depends on:
Blocks: cleana11y
  Show dependency treegraph
 
Reported: 2013-05-08 01:57 PDT by alexander :surkov
Modified: 2013-05-17 09:52 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Takes FirePlatformEvent() code and makes it inline at the only call site per platform, removes declarations and definitions of the function. (7.53 KB, patch)
2013-05-15 08:28 PDT, Zach (:xuku)
tbsaunde+mozbugs: review+
Details | Diff | Review
Updated with requested changes (7.25 KB, patch)
2013-05-16 18:31 PDT, Zach (:xuku)
no flags Details | Diff | Review

Comment 1 Trevor Saunders (:tbsaunde) 2013-05-08 12:27:34 PDT
why can't we just put all that code in HandleAccevent()?
Comment 2 alexander :surkov 2013-05-08 17:30:27 PDT
it seems ok
Comment 3 alexander :surkov 2013-05-13 17:53:04 PDT
assigning to Zach per email.
Comment 4 Zach (:xuku) 2013-05-15 08:28:47 PDT
Created attachment 749908 [details] [diff] [review]
Takes FirePlatformEvent() code and makes it inline at the only call site per platform, removes declarations and definitions of the function.
Comment 5 Trevor Saunders (:tbsaunde) 2013-05-16 17:54:26 PDT
Comment on attachment 749908 [details] [diff] [review]
Takes FirePlatformEvent() code and makes it inline at the only call site per platform, removes declarations and definitions of the function.

> AccessibleWrap::HandleAccEvent(AccEvent* aEvent)
> {
>   NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;
> 
>   nsresult rv = Accessible::HandleAccEvent(aEvent);
>   NS_ENSURE_SUCCESS(rv, rv);
> 
>-  return FirePlatformEvent(aEvent);
>-
>-  NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT;
>-}
>-
>-nsresult
>-AccessibleWrap::FirePlatformEvent(AccEvent* aEvent)
>-{
>   NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;

I think you can remove this and then you won't need the second one at the end of the function.
Comment 6 Zach (:xuku) 2013-05-16 18:31:28 PDT
Created attachment 750837 [details] [diff] [review]
Updated with requested changes
Comment 7 Ryan VanderMeulen [:RyanVM] 2013-05-17 06:29:39 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/c66d8ea1b2f1
Comment 8 Ryan VanderMeulen [:RyanVM] 2013-05-17 09:52:40 PDT
https://hg.mozilla.org/mozilla-central/rev/c66d8ea1b2f1

Note You need to log in before you can comment on or make changes to this bug.