869907 - Inconsistent comments of plural forms strings

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Khaled Hosny]

Attachment: Patch

Currently there is no way to programitically tell which strings are plurals strings and which are not, and several tools (compare-locales, translate toolkit) rely on the comments to identify such strings, so we need them to be as uniform as possible.

The attached patch adds few missing comments and fixes few others to fellow the conventions used everywhere else.

Comment 1

[Axel Hecht [:Pike]]

Comment on attachment 746917 [details] [diff] [review]
Patch

Review of attachment 746917 [details] [diff] [review]:
-----------------------------------------------------------------

Khaled, thanks for the bug and the patch. Looks good to me, but we'll want a real peer of browser and toolkit to review.

Blair, just some comments to make tools better detect the use of the plural forms here.

Comment 2

[Gordon P. Hemsley [:GPHemsley]]

Comment on attachment 746917 [details] [diff] [review]
Patch

Review of attachment 746917 [details] [diff] [review]:
-----------------------------------------------------------------

I see that an existing note (on popupWarning.message) says "Semicolon-separated list of plural forms." while all the new notes (and some existing notes) say "Semi-colon list of plural forms."

I think all the notes should be updated to match the existing popupWarning.message note, as that makes better sense in English (and "semicolon" is generally not hyphenated).

Comment 3

[Khaled Hosny]

Attachment: Patch

New patch, changing all occurrences of “Semi-colon” to “Semicolon-separated”.

Comment 4

[Axel Hecht [:Pike]]

Khaled, thanks again. I landed this on inbound for you, https://hg.mozilla.org/integration/mozilla-inbound/rev/1392f1c0008d.

This bug will get resolved as fixed when that merges to central over the day.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1392f1c0008d