Closed Bug 869907 Opened 7 years ago Closed 7 years ago

Inconsistent comments of plural forms strings

Categories

(Core :: Localization, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dr.khaled.hosny, Assigned: dr.khaled.hosny)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
Currently there is no way to programitically tell which strings are plurals strings and which are not, and several tools (compare-locales, translate toolkit) rely on the comments to identify such strings, so we need them to be as uniform as possible.

The attached patch adds few missing comments and fixes few others to fellow the conventions used everywhere else.
Comment on attachment 746917 [details] [diff] [review]
Patch

Review of attachment 746917 [details] [diff] [review]:
-----------------------------------------------------------------

Khaled, thanks for the bug and the patch. Looks good to me, but we'll want a real peer of browser and toolkit to review.

Blair, just some comments to make tools better detect the use of the plural forms here.
Attachment #746917 - Flags: review?(bmcbride)
Attachment #746917 - Flags: feedback+
Comment on attachment 746917 [details] [diff] [review]
Patch

Review of attachment 746917 [details] [diff] [review]:
-----------------------------------------------------------------

I see that an existing note (on popupWarning.message) says "Semicolon-separated list of plural forms." while all the new notes (and some existing notes) say "Semi-colon list of plural forms."

I think all the notes should be updated to match the existing popupWarning.message note, as that makes better sense in English (and "semicolon" is generally not hyphenated).
Attached patch PatchSplinter Review
New patch, changing all occurrences of “Semi-colon” to “Semicolon-separated”.
Attachment #746917 - Attachment is obsolete: true
Attachment #746917 - Flags: review?(bmcbride)
Attachment #746997 - Flags: review?(bmcbride)
Attachment #746997 - Flags: review?(bmcbride) → review+
Assignee: nobody → khaledhosny
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Khaled, thanks again. I landed this on inbound for you, https://hg.mozilla.org/integration/mozilla-inbound/rev/1392f1c0008d.

This bug will get resolved as fixed when that merges to central over the day.
Target Milestone: --- → mozilla23
https://hg.mozilla.org/mozilla-central/rev/1392f1c0008d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.