86992 - Copies and Folders panel is too big

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Blake Ross]

Screenshot says it all.

Comment 1

[Blake Ross]

URL is http://kerz/mail.gif.

I notice in the other bug that the panel fit in your screenshots.  Please create 
a new profile so the window is the size it will be for everyone else when 
testing your stuff.  I can only hope that you didn't see this problem to check 
something like this in.

Comment 2

[kmurray1115]

"I can only hope that you didn't see this problem to check 
something like this in."

Bhuvan, are you purposely doing this to appear human? ;-)

Looks like a spacing issue, can you get this in 9.2?

Comment 3

[racham]

Looks like it's problem only for every first time user views that panel. 
Clicking on some other settings (like Server settings) and coming back to Copies 
and Folders seem to have magically fixed it.

BTW, I haven't noticed this problem in the Classic skin mode.

I will talk to Joe about this weirdness.

Anyway, I am cutting on all separators so that we can provide better 
accommodation always.

Comment 4

[racham]

Adding Joe Hewitt to the cc list.

Looks like the grid layout I used to arrange the UI seemed to getting drawm much 
before the images and items are loaded. So, the UI looks all cut off first time. 
According to this hypothesis, the reason it works fine the second time (when 
you click back on this setting && ofcourse resize will fix it in a different 
way by providing more area for the layout)is that all elements are available and 
are drawn properly.

Hewitt suggested that I can try simulating the grid layout using boxes and see 
if we can get around this problem. I will give a shot at that.

Adding Eric Vaughan to the cc list for if he has any ideas on other easier 
alternatives here.

Comment 5

[racham]

Attachment: Patch (mozilla/mailnews) to fix the UI problems

Comment 6

[racham]

Attachment: mozilla/themes diffs - a name change to one of the classes

Comment 7

[racham]

Attachment: snapshot of CopiesAndFolders panel - modern skin

Comment 8

[racham]

Attachment: snapshot of CopiesAndFolders panel - classic skin

Comment 9

[racham]

After changing the layout to use boxes and removing the seperators to improve
the UI, CopiesAndFolders panel look like the images posted in attachments
(39884, 39885).

Modern skin is still slightly off in terms of height. But we do see all the
elements that need to be there in the panel. There is a need to rework all our
panels to reduce the accountmanager window size and adjust the prefs in the
panels accordingly. Unless there is a better short term solution, I would like
to proceed with this patch for now.

Any input is welcome.

Seth & Hewitt, please review. thanks.

bhuvan

Comment 10

[racham]

Note : Screenshots are taken on a brand new profile's mail account.

Comment 11

[racham]

Scott,

Can we consider this for nsBranch ? It is certainly better than the status quo.

Comment 12

[(not reading, please use [e-mail] instead)]

you wrote:  "Looks like the grid layout I used to arrange the UI seemed to
getting drawn much before the images and items are loaded."

are you just working around a grid bug?  are there other areas in the app where
grid has this problem?

Comment 13

[Blake Ross]

Can we get this checked in?

Comment 14

[(not reading, please use [e-mail] instead)]

setting to 0.9.4  

it's not something that would hold up 0.9.3

it still seems like we're working around a grid bug.

but blake, if you want to review the two patches, I'll sr.
when racham gets back from vacation, he can drive this in.

Comment 15

[Scott MacGregor]

Bhuvan can you drive getting this patch checked in soon? If you can't get to it
soon then we need to push this off to .9.5 per the triage meeting today. So feel
free to change this to .9.5 if you can't get the patch in.

Comment 16

[racham]

Filed bug 95442 to take care of the grid layout problem. 

However, I tried to reproduce this bug on my laptop (with latest trunk build
downloaded from sweetlou [2001081504], with a brand new profile). I noticed that
the situation wrt to menulists is improved. They are getting drawn properly. May
be the grid bug is fixed or my settings are changed. Blake, can you confirm if
you still see the problem where menulists are getting cut on the righthand side. 
nbaca, karen, can you also check if you can reproduce this bug as posted at
http://kerz/mail.gif ? My update build is going on. I will check again once that
is done.

If the grid layout problem is fixed, that leaves us with the part of fixing the
height of the panel. I can get rid of the separators whereever possible so that
we can get all the components into the view.

Comment 17

[Blake Ross]

Yeah, now it's just a height problem.

Comment 18

[Ninoschka Baca]

Build 2001-08-15-04: WinMe, I see the same problem with the height issue.

Comment 19

[racham]

Attachment: copy_and_folders panel today (screen shot 1)

Comment 20

[racham]

Attachment: new patch (deleting separators) - v1

Comment 21

[racham]

Attachment: copy_and_folders panel (screen shot 2) - classic skin - with patch applied

Comment 22

[racham]

Attachment: copy_and_folders panel (screen shot 3) - modern skin - with patch applied

Comment 23

[racham]

After removing the separators to improve on the height issue, things looked fine  
with clasic skin. Modern skin still doesn't show the panel as expected (not even 
as it was like in attachment #39884 [details]). I noticed that the icons have 
changed/improved since that attachment (#39884) was posted. But it looks like 
that demanded more space around the widgets.

Joe, is there any way to tweak this further via css rules..?

Comment 24

[racham]

We already have class named 'small-margin' to help us in these kind of 
situations (with minimal margin values). Thanks Joe.

New patch, which works with both classic and modern skins, coming up...

Will also post updated screen shots.

Comment 25

[racham]

Attachment: new patch (delete separators & use smaller margins), v2

Comment 26

[racham]

Attachment: screen shot of copy & folders panel, with version 2 patch

Comment 27

[racham]

Attachment: screen shot of copy & folders panel - modern skin, with version 2 patch

Comment 28

[racham]

Joe, 

Please review the latest patch (#46535).

thanks.

Comment 29

[(not reading, please use [e-mail] instead)]

r or sr=sspitzer, which ever you need.

Comment 30

[Karen Huang]

I will take this bug for verification.

Comment 31

[racham]

FYI :

I did correct 
<groupbox orient="vertical" class="small=margin">
to
<groupbox orient="vertical" class="small-margin">

in my patch.

Comment 32

[Sean Su]

r=ssu for the last patch (id=46535) with the fix of "small=margin" to 
"small-margin".

Comment 33

[Robert O'Callahan (:roc) (email my personal email if necessary)]

a=roc+moz on behalf of drivers

Comment 34

[racham]

Fix checked in.

Comment 35

[racham]

Marking fixed.

Comment 36

[Karen Huang]

Veriifed on all the platforms WinNT, Mac OSX & Linux for 10-15-05-0.9.4 builds.