870113 - Switch GetFontImpl to Fira Sans

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Michael Wu [:mwu]]

Attachment: Switch GetFontImpl to Feura Sans

Don't know if this matters, but we might as well switch it over. If this function matters in selecting the correct font, we can uplift to b2g18.

Comment 1

[Jonathan Kew [:jfkthame]]

Comment on attachment 747136 [details] [diff] [review]
Switch GetFontImpl to Feura Sans

Review of attachment 747136 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense. I'm not sure how much this actually gets used on b2g - it could be that the font name is always being set explicitly via CSS, without using "system" font names - but there's certainly no point in returning the wrong name here!

Comment 2

[Michael Wu [:mwu]]

https://hg.mozilla.org/projects/birch/rev/afc08927188a

Comment 3

[Ryan VanderMeulen [:RyanVM]]

For some inexplicable reason, this caused B2G mochitest-2 failures. Backed out.
https://hg.mozilla.org/projects/birch/rev/6e6ec8a34321

https://tbpl.mozilla.org/php/getParsedLog.php?id=22776796&tree=Birch

Comment 4

[Michael Wu [:mwu]]

Attachment: Switch GetFontImpl to Fira Sans

Name updated. Going to try to land again.

Comment 5

[Michael Wu [:mwu]]

https://tbpl.mozilla.org/?tree=Try&rev=61027a53b50a

Comment 6

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8eaa41d5da30

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8eaa41d5da30