870371 - Add Javascript interface to Android OrderedBroadcast

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Android, defect, P1)

Description

[Nick Alexander :nalexander [he/him]]

We are designing Firefox Health Report on Android to mostly be implemented in Java, and with this design we need a way to trigger shuttling a report from Java to Javascript.

One way to do this is for JS to trigger Java (Fennec) to send an Android Ordered Broadcast, which a background service can then respond to.  Decoupling in this way makes it possible to swap in testing code from the Android Sync git repository.

Comment 1

[Richard Newman [:rnewman]]

I'm happy with this, modulo your weird outdated JavaScript conventions ;)

See GitHub comments.

Fold and put a patch here, and I'll rubberstamp.

Comment 2

[Nick Alexander :nalexander [he/him]]

Here's a try build exercising Javascript robocop tests:

https://tbpl.mozilla.org/?tree=Try&rev=63977c0b128c

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 870371 - Add Javascript interface to Android OrderedBroadcast. r=rnewman

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 870371 - Android OrderedBroadcast tests. r=rnewman

Comment 5

[Nick Alexander :nalexander [he/him]]

https://tbpl.mozilla.org/?tree=Try&rev=1b77c88798f2

Comment 6

[Nick Alexander :nalexander [he/him]]

Mercurial 2.0.2 seems to have a Mac OS X filename case bug.  Try

https://tbpl.mozilla.org/?tree=Try&rev=85dad1ab2455

Comment 7

[Richard Newman [:rnewman]]

Comment on attachment 748285 [details] [diff] [review]
Bug 870371 - Add Javascript interface to Android OrderedBroadcast. r=rnewman

Review of attachment 748285 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/modules/Makefile.in
@@ +12,4 @@
>  EXTRA_JS_MODULES = \
>    LightweightThemeConsumer.jsm \
>    JNI.jsm \
> +	OrderedBroadcast.jsm \

Use the right flavor of whitespace.

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/services/services-central/rev/a0be79631c9e
https://hg.mozilla.org/services/services-central/rev/a5af2642d1d7

Comment 9

[Richard Newman [:rnewman]]

https://hg.mozilla.org/mozilla-central/rev/a0be79631c9e
https://hg.mozilla.org/mozilla-central/rev/a5af2642d1d7

Comment 10

[Geoff Brown [:gbrown]]

Comment on attachment 748286 [details] [diff] [review]
Bug 870371 - Android OrderedBroadcast tests. r=rnewman

Review of attachment 748286 [details] [diff] [review]:
-----------------------------------------------------------------

BTW, I am happy to provide feedback on your robocop patches.

::: mobile/android/base/tests/testOrderedBroadcast.java.in
@@ +57,5 @@
> +
> +        mAsserter.dumpLog("Unregistering org.mozilla.gecko.test.receiver broadcast receiver");
> +
> +        if (mReceiver != null) {
> +            getActivity().getApplicationContext().unregisterReceiver(mReceiver);

Is it okay to call this after BaseTest.tearDown() has called finishOpenedActivities()?