870388 - Allow separator lines in html5 context menus

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[karl155]

The <hr> element is used to show separator lines in context menus.

Example from WHATWG (see URL):
<button type=menu menu=editmenu>Commands...</button>
<menu type="popup" id="editmenu">
 <menuitem type="radio" radiogroup="alignment" checked="checked"
          label="Left" icon="icons/alL.png" onclick="setAlign('left')">
 <menuitem type="radio" radiogroup="alignment"
          label="Center" icon="icons/alC.png" onclick="setAlign('center')">
 <menuitem type="radio" radiogroup="alignment"
          label="Right" icon="icons/alR.png" onclick="setAlign('right')">
 <hr>
 <menuitem type="command" disabled
          label="Publish" icon="icons/pub.png" onclick="publish()">
</menu>

Comment 1

[Thomas Wisniewski]

Attachment: 870388-support-hr-in-menu.diff

Here's a trivial patch which seems to do the job just fine.

Try run seems ok, just some unrelated stuff: https://treeherder.mozilla.org/#/jobs?repo=try&revision=716fd217ca48

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8783134 [details] [diff] [review]
870388-support-hr-in-menu.diff

Review of attachment 8783134 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay in getting to this.

Comment 3

[Thomas Wisniewski]

Thanks! The patch still applies cleanly on inbound, so requesting check-in.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dd49fb530d4
Support <hr> separators in <menu>. r=mrbkap

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3dd49fb530d4

Comment 6

[Eric Shepherd [:sheppy]]

The following pages have been updated:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/contextMenu
https://developer.mozilla.org/en-US/Firefox/Releases/51

While I was in the <menu> and contextMenu pages, I added some other compatibility info updates and beefed up the explanatory text to be more detailed as well.

This should do the trick.