Allow separator lines in html5 context menus

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: karl156, Assigned: wisniewskit)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla51
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
The <hr> element is used to show separator lines in context menus.

Example from WHATWG (see URL):
<button type=menu menu=editmenu>Commands...</button>
<menu type="popup" id="editmenu">
 <menuitem type="radio" radiogroup="alignment" checked="checked"
          label="Left" icon="icons/alL.png" onclick="setAlign('left')">
 <menuitem type="radio" radiogroup="alignment"
          label="Center" icon="icons/alC.png" onclick="setAlign('center')">
 <menuitem type="radio" radiogroup="alignment"
          label="Right" icon="icons/alR.png" onclick="setAlign('right')">
 <hr>
 <menuitem type="command" disabled
          label="Publish" icon="icons/pub.png" onclick="publish()">
</menu>
(Reporter)

Updated

6 years ago
Blocks: 617528

Updated

5 years ago
Blocks: 897102
(Assignee)

Comment 1

3 years ago
Here's a trivial patch which seems to do the job just fine.

Try run seems ok, just some unrelated stuff: https://treeherder.mozilla.org/#/jobs?repo=try&revision=716fd217ca48
Attachment #8783134 - Flags: review?(mrbkap)
Comment on attachment 8783134 [details] [diff] [review]
870388-support-hr-in-menu.diff

Review of attachment 8783134 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay in getting to this.
Attachment #8783134 - Flags: review?(mrbkap) → review+
Assignee: nobody → wisniewskit
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 3

3 years ago
Thanks! The patch still applies cleanly on inbound, so requesting check-in.
Keywords: checkin-needed

Comment 4

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dd49fb530d4
Support <hr> separators in <menu>. r=mrbkap
Keywords: checkin-needed

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3dd49fb530d4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Keywords: dev-doc-needed
The following pages have been updated:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/contextMenu
https://developer.mozilla.org/en-US/Firefox/Releases/51

While I was in the <menu> and contextMenu pages, I added some other compatibility info updates and beefed up the explanatory text to be more detailed as well.

This should do the trick.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.