870412 - Persona unable to retrieve localStorage state on v1.0.1; breaks marketplace, persona

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

The automatic-login feature of Persona has stopped working on v1.0.1.  This breaks marketplace payments.

Persona appears to be unable to retrive login state from localStorage on v1.0.1.


For tef, Persona had three patches uplifted.  My initial thought was that one of these was the culprit.

I have reverted to gecko @7e9e10889942 (hg.mozilla.org) and gaia @89a9c5de (github.com), which undoes all of our changes.  I rebuilt and flashed to device (unagi), and Persona is still broken.  (At this point, the most recent Persona patch in v1.0.1 is from December.)

At the same time, it is noteworthy that Persona on b2g18 + v1-train works as it should (and of course all our tef patches are in those branches as well); it is not broken.

I have confirmation from :zac that this is the case: b2g18 good, v1.0.1 bad


Steps to reproduce, v1.0.1:
- in the b2g browser, go to native.123done.org
- sign in with persona
- reload the page
- you will be logged out on reload

What should happen is that on reload you should be automatically signed in.  Persona is behaving as though it is unable to access data from cookies or localStorage.


I don't know what the cause of this is, but the consequences are severe.  Marketplace's login flow depends on this silent assertion delivery from Persona.  Furthermore, I fear Persona may be the canary in the coal mine, so to speak, and that we have stumbled across a problem that could have even broader repercussions.


Profuse thanks in advance to everyone who can help us all resolve this one.


ps Persona had one other patch this year that was not uplifted to tef, and that was a patch to cause the persona iframe to be cleaned up when not in use (bug 839500).  That patch is in b2g18, but not v1.0.1.  Since Persona was working before and after that patch landed in b2g18, I think it's unlikely to have had an effect in itself, but I mention it in case it seems related to anything else.

Comment 1

[Jason Smith [:jsmith]]

I can confirm I can reproduce this bug on a 5/9/2013 1.01 unagi build.

Comment 2

[Edwin Wong [:edwong]]

I can repro or 5/9/2013 1.01 inari build.  Working on isolating the regression.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thanks to Shane Tomlinson's wizardry, we think we have a completely server-side fix for this.  We are testing now.

Comment 4

[Jason Smith [:jsmith]]

This might be all server-side. I'll wait for confirmation, but for now, I'll pull this off the blocking radar until we get more information.

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

(In reply to Jason Smith [:jsmith] from comment #4)
> This might be all server-side. I'll wait for confirmation, but for now, I'll
> pull this off the blocking radar until we get more information.

Agreed.  I think we can all breathe ...

Comment 6

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

The fix has been pushed to native-persona.org

And to the train that will be persona.org in production when we go to market.  (So it will be in persona.org staging next week)

w00t

Comment 7

[Jason Smith [:jsmith]]

Closing then.