870429 - Remove locales public field from Make model

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[David Humphrey (:humph)]

We seem to have both locale and locales in our Make model (make.js):

  Make.publicFields = [ "url", "contentType", "locale", "locales",
                        "title", "description", "author",
                        "published", "tags", "thumbnail", "email", "remixedFrom" ];

Only locale should be there.

Comment 1

[David Humphrey (:humph)]

Igor, the code in question is here:

https://github.com/mozilla/MakeAPI/blob/master/lib/models/make.js#L125

Comment 2

[Simon C. Wex]

I think the original aim of this was "locale" was the locale of this make, the "locales" was a list of other makes translated from this one. Either way, we're not using it and should probably be removed for now.

Comment 3

[Igor Entaltsev [:igoryen]]

Attachment: https://github.com/ksedge/MakeAPI/pull/1

Comment 4

[Igor Entaltsev [:igoryen]]

Attachment: https://github.com/mozilla/MakeAPI/pull/72

Comment 5

[Kieran Sedgwick (:sedge)]

Comment on attachment 757578 [details] [review]
https://github.com/mozilla/MakeAPI/pull/72

Rebase into 1 commit, and then you have the r+

Comment 6

[Igor Entaltsev [:igoryen]]

Attachment: https://github.com/mozilla/MakeAPI/pull/72

Comment 7

[Kieran Sedgwick (:sedge)]

Comment on attachment 758031 [details] [review]
https://github.com/mozilla/MakeAPI/pull/72

Looks good, I will merge.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/d1e0ae94c5b97ae2963d4852274ad19d65016381
Merge pull request #72 from igoryen/bug870429

Bug 870429 - Remove locales public field from Make model