87045 - Getting exception in general.xml pressing View when looking at plugin documents (pdf, etc)

Status: RESOLVED WORKSFORME

(SeaMonkey :: UI Design, defect, P2)

Description

[Henrik Gemal]

If you go to:
ftp://ftp.iambic.com/pilot/actionnames/anmanual.pdf
and the try to use the View menuitem you get:

Error: [Exception... "Component returned failure code: 0x80004002 
(NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x80004002 
(NS_NOINTERFACE)"  location: "JS frame :: 
chrome://global/content/bindings/general.xml#browser.markupDocumentViewer 
(getter) :: onget :: line 0"  data: no]
Source File: 
chrome://global/content/bindings/general.xml#browser.markupDocumentViewer 
(getter)
Line: 0

Comment 1

[Jacob Kjome]

I'm also seeing this with build 2001062004 on Win2k (SP2)

Jake

Comment 2

[Jacob Kjome]

BTW, when I closed the window after viewing the following URL:
ftp://ftp.iambic.com/pilot/actionnames/anmanual.pdf

I got a crash!

Talkback ID: TB32005431Q

adding crash keyword and upping severity to major.

Jake

Comment 3

[Henrik Gemal]

I think perhaps you should open a new bug on the crash.

Comment 4

[Jacob Kjome]

filed bug 87128 to cover crash.

Jake

Comment 5

[Paul Chen]

nav triage team:

Marking p2, mozilla0.9.3, nsBranch, and nsbeta1+

Comment 6

[Paul Chen]

With fix for 80105, this no longer crashes. View menu still doesn't appear; it's
really strange because when you mouse over the view menu but don't click it,
it's drawn depressed as if you clicked on it. Weird. Anyway, I think this should
be pushed out to mozilla1.0. Removing crash and nsBranch keywords, setting
target milestone to mozilla1.0

Comment 7

[Viswanath Ramachandran]

this is a bad breakage of functionality. If we're shipping Netscape 6.1 with 
this, we realy shd fix the next time around. Moving up to mozilla0.9.5. 

Comment 8

[Paul Chen]

Took some time to look into this today. nsMenuFrame::OnCreate() exists with 
PR_FALSE here 
http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/nsMenuFrame.cpp#1592

The reason this happens is because status = nsEventStatus_eConsumeNoDefault, 
and the reason for that is the exception noted in this bug. My current guess is 
that the browserContentListener is the one being asked to QI to something it 
can't.

Comment 9

[Peter Trudelle]

Mass-moving lower-priority 0.9.5 bugs off to 0.9.6 to make way for remaining
0.9.4/eMojo bugs, and MachV planning, performance and feature work. If you
disagree with any of these targets, please let me know.

Comment 10

[Paul Chen]

Ok, found the problem. In viewZoomOverlay.js, the calls to
getMarkupDocumentViewer() are causing the exceptions. I've got a patch for that.
Now the view menu shows up; however, a bunch of other view menu items cause js
errors because we have no document. Sigh.

Comment 11

[Paul Chen]

Attachment: use try-catch around calles to getMarkupDocumentViewer()

Comment 12

[Henrik Gemal]

*** Bug 105590 has been marked as a duplicate of this bug. ***

Comment 13

[Paul Chen]

Attachment: version 2, forgot catch variable name, oops ;-)

Comment 14

[Paul Chen]

pushing to mozilla0.9.7

Comment 15

[Paul Chen]

Won't get time to look at this for mozilla0.9.7, moving to mozilla0.9.8

Comment 16

[Peter Trudelle]

->hewitt

Comment 17

[Peter Trudelle]

nsbeta1- per Nav triage team, if this crashes in recent builds, please renominate.

Comment 18

[Wayne Mery (:wsmwk)]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050604
using http://www.adobe.com/epaper/spotlights/comicsone/pdfs/Comics_One.pdf
(ftp://ftp.iambic.com/pilot/actionnames/anmanual.pdf no longer exists)