870463 - (Australis) Set a minimum width for the location bar and search container

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

As more toolbaritems get put in the toolbar, the location bar and search container should not shrink down to an unusable size. We should set a minimum width for these.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Hey, not sure if this belongs in theme or content CSS.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 747532 [details] [diff] [review]
Patch

Review of attachment 747532 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with these being in browser/base/content/browser.css, unless we find that individual OS's need something special. Thanks!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/projects/jamun/rev/d6f153878d91

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Landed in UX as https://hg.mozilla.org/projects/ux/rev/d6f153878d91

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/d6f153878d91

Comment 7

[[:Aleksej]]

I don't use the search container all the time (I use bookmark and search keywords), and usually have it at the minimum possible size.  When I use it, it's usually for dictionary sites, so I don't enter very long words.

This patch made it impossible to "stow" the search container without switching to Customize mode.  The patch says "min-width: 25ch;", which apparently translates to 20 zeros due to the icons.

Note that URLs can also be long, and at this page Firefox shows "Mozilla Foundation (US)" to the left of the URL.  With Add-on Bar gone, people may add icons to the location bar more often.

Please remove the limit, or reduce it to something like 15ch.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

How were you "stowing" it before? You just had it smaller and off to the side? Did you make it larger when you went to use it?

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

I talked with Aleksej on IRC and suggested filing a new bug.

Comment 10

[[:Aleksej]]

I guess it's safe to assume it's fixed, because it caused bug 941235 (also verified).