Closed Bug 870504 Opened 10 years ago Closed 10 years ago

nsBlockFrame::ComputeFinalSize is unnecessarily virtual

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file)

nsBlockFrame's method "ComputeFinalSize" is virtual, but there's only one implementation and only one caller (both in nsBlockFrame):

http://mxr.mozilla.org/mozilla-central/search?string=ComputeFinalSize

Looks like we can de-virtualize it.
For the record, this method was originally marked as virtual back in 1998, in this commit:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/generic&command=DIFF_FRAMESET&file=nsBlockFrame.h&rev2=3.40&rev1=3.39

This was done as part of making it override its base class's method (the base class being nsBaseIBFrame).

nsBaseIBFrame is long-gone, needless to say.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #747581 - Flags: review?(matspal)
Comment on attachment 747581 [details] [diff] [review]
fix

r=mats
Attachment #747581 - Flags: review?(matspal) → review+
Keywords: checkin-needed
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/6312fc1ea87a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.