Closed
Bug 870504
Opened 12 years ago
Closed 12 years ago
nsBlockFrame::ComputeFinalSize is unnecessarily virtual
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(1 file)
|
1.53 KB,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
nsBlockFrame's method "ComputeFinalSize" is virtual, but there's only one implementation and only one caller (both in nsBlockFrame):
http://mxr.mozilla.org/mozilla-central/search?string=ComputeFinalSize
Looks like we can de-virtualize it.
|
Assignee | |
Comment 1•12 years ago
|
||
For the record, this method was originally marked as virtual back in 1998, in this commit:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/generic&command=DIFF_FRAMESET&file=nsBlockFrame.h&rev2=3.40&rev1=3.39
This was done as part of making it override its base class's method (the base class being nsBaseIBFrame).
nsBaseIBFrame is long-gone, needless to say.
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Comment on attachment 747581 [details] [diff] [review]
fix
r=mats
Attachment #747581 -
Flags: review?(matspal) → review+
|
|
Assignee | |
Updated•12 years ago
|
|
|
Assignee | |
Comment 4•12 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•