Closed Bug 870603 Opened 11 years ago Closed 11 years ago

[MMS] Multi-recipient: completing # or auto-search entry with ; or ENTER erases content

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed)

Status:
RESOLVED FIXED
Milestone:
1.1 CS (11may)
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: danheberden, Assigned: rwaldron)

References

Details

Attachments

(1 file)

Fix for 870603
37 bytes, text/x-github-pull-request
gnarf
: review+
Details | Review 
In latest moz-central, entering a number or typing a contact name and then pressing ; or ENTER erases the contact element. The top of this is actually barely visible, thus, it looks like the tile that represents the contact is created with no content, possibly.
Assignee: nobody → waldron.rick
blocking-b2g: --- → leo?
Depends on: 837994
Priority: -- → P1
Whiteboard: [NO_UPLIFT]
Target Milestone: --- → 1.1 CS (11may)
The actual problem is that event.preventDefault() appears to have no effect.
Vivien, we have discovered this with Gaia (master) + Gecko (mozilla-central). Any idea about what is happening here? THanks!
Flags: needinfo?(21)
It appears KeyboardEvent was renamed KeyEvent? This caused another condition fail which resulted in event.preventDefault() never being called.

Anyway, I fixed this by not using an instanceof check:

https://github.com/rwldrn/gaia/commit/e873a89327e041db898cebdc1763170a457a6648
Attached file Fix for 870603 — 

        Attachment #748025 -
        Flags: review?(fbsc)
blocking-b2g: leo? → leo+

    
  

        Attachment #748025 -
        Flags: review?(fbsc) → review+

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/d9b84c1617828a24952944ff86935532e2f18501
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(21)
Resolution: --- → FIXED

    
  
Whiteboard: [NO_UPLIFT]

    
    

    
  
v1-train: 969584d

          status-b2g18:
          --- → fixed
Attachment mime type: text/plain → text/x-github-pull-request

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: