870609 - [MMS] Recipients field. Area is cropping the view

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: shows the cropped bubbles

When adding recipients, the white area on the top is cropping the "to" bubbles.

See attachment that illustrates the problem.

Comment 1

[Rick Waldron [:rwaldron]]

That's exactly according to the v8 wireframes...

In an earlier iteration, I had them hidden then allowed them to be revealed because the wireframes illustrate them that way.

Comment 2

[Victoria Gerchinhoren [:vicky]]

Hi Rick,
Have you seen the screenshot? They must be partially hidden, that's right, but there's an error in the mark up where by there's a gap between the cropping of the bubble and the header, it is an extra space that does not need to be there. It's an obvious mistake.

Comment 3

[Rick Waldron [:rwaldron]]

Ok, _that_ space. Thank you for clarifying

Comment 4

[Rick Waldron [:rwaldron]]

Bug introduced here: https://github.com/mozilla-b2g/gaia/pull/9281

Patch to follow

Comment 5

[Rick Waldron [:rwaldron]]

Please note that Borja actually instructed me to make this worse in a code review, resulting in display shown in the attachment.

Comment 6

[Rick Waldron [:rwaldron]]

Attachment: Illustrates gap issue as a result of unrelated code review.

Comment 7

[Borja Salguero [:borjasalguero]]

Attachment: Bug 747678 fixed in other patch.

Comment 8

[Borja Salguero [:borjasalguero]]

Is quite easy to understand. 
- https://bugzilla.mozilla.org/show_bug.cgi?id=870612
The problem was https://bug870612.bugzilla.mozilla.org/attachment.cgi?id=747678, and you are fixing it in line https://github.com/bocoup/gaia/pull/6/files#L0R642. So you *dont* need to change more stuff right? This is the result https://bug870609.bugzilla.mozilla.org/attachment.cgi?id=748100, so it's working.

- https://bugzilla.mozilla.org/show_bug.cgi?id=870609
Here the problem is that recipients & 'TO' label are not aligned at all. So as you can see are *completely* different bugs.

Take into a consideration that in my review Im trying to help you to identify where is the problem. If you have any doubt dont hesitate to ask us.

Comment 9

[Victoria Gerchinhoren [:vicky]]

Attaching specs to illustrate the overall spacing an relationship between elements.

Comment 10

[Victoria Gerchinhoren [:vicky]]

Attachment: specs for layout

Comment 11

[Daniel Coloma:dcoloma]

tef? is to block for 1.0.1 releases and MMS is not part of that release, I am removing the nomination, not sure what flag/version you want to use here.

Comment 12

[Rick Waldron [:rwaldron]]

Can you confirm this has been fixed or needs additional attention?

Comment 13

[Victoria Gerchinhoren [:vicky]]

I see it fixed.