870625 - Electrolysis: Add-on installation from addons.mozilla.org should work

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Comment 1

[Tom S [:evilpie]]

Attachment: addon-install

I am very happy! All this code is e10s ready and just seems work. The code was just triggering the wrong path, because .contentWindow works in e10s mode.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 786591 [details] [diff] [review]
addon-install

Review of attachment 786591 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/addonManager.js
@@ +182,5 @@
>              },
>            };
>          }
>          var window = null;
> +        if (!aMessage.target.getAttribute('remote')) {

Can we check that the value of this is "true"?

Comment 3

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b23e47f15707

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b23e47f15707

Comment 5

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on Latest Nightly using Ubuntu 12.10 x86:

Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0 (20130901030218)