870628 - [MMS] Text in input box can overflow below the interface. Regression.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Borja Salguero [:borjasalguero]]

Layout is completely broken composing a message.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Layout messed up.

Comment 2

[greg]

I cannot reproduce this. Can you give me software details / device details / steps to reproduce?

Comment 3

[Borja Salguero [:borjasalguero]]

2 main steps.

STEP 1:
- Add 8 recipients with 'mmmmmmmmmmmmm' text (it's for having more than 1 line in recipients)
- Type a lot of text in the input field (or tapping ENTER) until reaching the header
- Continue tapping 'ENTER'
- A weird effect appears (a small gap appears). Attachment 1 [details] [diff]

STEP 2:
- Click 'home', open the app from background to foreground (this is only for hiding the keyboard)
- Tap 'ENTER' so many times, so fast.
- Layout is completely broken. Attachment 2 [details] [diff]

I was checking this with Corey and we were reproducing this in his device.

Comment 4

[Borja Salguero [:borjasalguero]]

Attachment: Attachment 1. Small gap appears.

Comment 5

[Borja Salguero [:borjasalguero]]

Attachment: Attachment 2. Layout completely broken.

Comment 6

[Corey Frang [:gnarf]]

Attachment: https://github.com/bocoup/gaia/pull/10

Comment 7

[Corey Frang [:gnarf]]

Comment on attachment 748273 [details] [diff] [review]
https://github.com/bocoup/gaia/pull/10

Bad approach entirely, I thought this fixed a problem but it didn't

Comment 8

[Steve Chung [:steveck]]

Attachment: Small fix patch

Comment 9

[Corey Frang [:gnarf]]

Comment on attachment 748401 [details]
Small fix patch

Tested with the steps to reproduce, can no longer reproduce this.

Comment 10

[Corey Frang [:gnarf]]

https://github.com/mozilla-b2g/gaia/commit/c070f16e5dae71081cc12d61b20573148b70587a

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

triage: leo+ for a regression and broken UI

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train:110e899

Comment 13

[mdaniloff]

Verified fixed on: 

Build ID: 20130806071254
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 4c1a20570e20f64782ba170c14604395c48f7381
Platform Version: 18.1

No text overflow occurs outside the boundaries