870683 - Call new Bluetooth APIs when user trying to switch audio output

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Eric Chou [:ericchou] [:echou]]

To pass Bluetooth certification, we create a set of API to operate audio link of Bluetooth (SCO) on bug 830213. The newly added APIs are:

DOMRequest ConnectSco();
DOMRequest DisconnectSco();
DOMRequest IsScoConnected();

We need Dailer support to call these APIs when users try to switch audio output among earpiece, speaker and Bluetooth headset.

Comment 1

[Eric Chou [:ericchou] [:echou]]

Nominate as tef+ since we can't pass BT certification without using Dialer UI to control SCO.

Comment 2

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Add audio owner for support audio part just in case.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/9756

Etienne, this change was made for BT certification. Based on the current API design, bluetooth adapter is needed in dialer app although I have some concerns on this. So I would like your opinion here. Thanks!

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 749215 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9756

Can't test the feature but code looks good!

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

If SCO disconnected (for example, BT headset turns off) during the call, do we really need to turn on speaker?
User can be scared that the audio path to speaker.

Test steps:
a. Bluetooth headset connected
b. Make a call
c. During the call, turn off BT headset
d. based on line 576 in oncall.js, speaker will be turned on

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

ConnectSco/DisconnectSco shall be lower case instead capitalized in oncall.js

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Shawn, I am not quite sure about the case you pointed out. If you have concern on it, let's remove the code here and create a follow up issue. 

As for this patch, I still need to add some logics checking the existence of bluetooth connection and the type of it. So that we will not call connectSco/disconnectSco all the time.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Etienne, I've refined the patch to avoid BT dependency. Shawn has already tested this patch. Could you help review it? Thanks!

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I've tested the following scenarios:
Scenario A:
1. Connected BT headset, during call session, turn off BT headset
2. Check audio path correctly switch back to earpiece

Scenario B:
1. Connected BT headset, during call session, switch to speaker, turn off BT headset
2. Check audio path correctly switch back to speaker
3. Switch to earpieces again and check audio path routed to earpieces

Scenario C:
1. Turn off Bt headset, make a phone call, during the call session, turn on BT headset
2. Check audio path correctly switch back to BT headset
3. Switch to speaker again check path to speaker

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 749215 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9756

r=me for the dialer part once the settings name is more specific.

Comment 11

[Evelyn Hung]

Comment on attachment 749215 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/9756

r=me with comment addressed. Thanks. :D

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Etienne, Evelyn, thanks for reviewing.

v1.0.1: https://github.com/mozilla-b2g/gaia/commit/92f7613c403f59f300fd38fccaf8dcdee640ede4

The tests were done using v1.0.1 only. The patch will be landed on master and v1-train after Shawn finishes the tests on both branches.

Comment 13

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Please land m-c and b2g18.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1-train: https://github.com/mozilla-b2g/gaia/commit/dfcf9b6d37c297360676bc796ed68984fdc1ca26
master: https://github.com/mozilla-b2g/gaia/commit/afa18ab380680afac268ed1c19ae101266c5212e