[websites]   entity is being parsed incorrectly on language names

VERIFIED FIXED

Status

www.mozilla.org
Bedrock
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Fernando Pereira Silveira, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 747948 [details]
AMO/Marketplace screenshot

Non-breaking space ( ) entity is being parsed incorrectly on AMO and Marketplace, perhaps on some other sites too...

Updated

5 years ago
Blocks: 816068
No longer blocks: 816068
(Reporter)

Comment 1

5 years ago
this bug is reflected on other sites too:
http://www.mozilla.org/pt-BR/firefox/new/
Component: Localization → Other
Product: addons.mozilla.org → Websites
Summary: [AMO/Marketplace]   entity is being parsed incorrectly → [websites]   entity is being parsed incorrectly on language names
Let's move the bug to www.mozilla.org where it will probably get more traction. 

An nbsp is escaped in the download box:
do Brasil
Component: Other → Bedrock
Product: Websites → www.mozilla.org
ok, the data is stored correctly but by default, Django (the framework that powers now most of our sites) escapes all & as &
The escaping can be cancelled in the template view on a per string basis, I am going to do that for our download buttons there.
Here is a pointer to my Pull Request for www.mozilla.org
https://github.com/mozilla/bedrock/pull/1095
Ok, this is fixed at the source in product-details in r118295, I replaced the html entity by a real nbsp in the string. CCing cmore as we talked about it on IRC

The real fix will happen when product-details are updated on mozilla.org and other sites (that is when we ship Firefox)
So this is fixed on download boxes:
https://www.mozilla.org/pt-BR/firefox/new/

Fixed on SUMO:
https://support.mozilla.org/fr/locales

and on AMO (footer) too:
https://addons.mozilla.org/fr/firefox/

Marking fixed.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

5 years ago
great! thanks ;-)

Comment 8

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/94f80a7e669f2a901ba82b270d66f31ebbf75f37
Bug 870776: Don't escape locale names from product-details in templates

https://github.com/mozilla/bedrock/commit/9b5805fc9f0dd42dd3f7f5a46b4ac03f3393c5e0
Merge pull request #1095 from pascalchevrel/Bug-870776-fix_escaped_nbsp_locale_name_download_button

Bug 870776 Don't escape locale names from product-details in templates
fixed on stage https://www.allizom.org/pt-BR/firefox/new/
verified fixed https://www.mozilla.org/pt-BR/firefox/new/
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.