Closed
Bug 870799
Opened 12 years ago
Closed 12 years ago
Update windowMap API to always use outer window id as parameter
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [ateamtrack: p=mozmill q=2013q2 m=3][mozmill-2.0])
Attachments
(1 file)
|
6.82 KB,
patch
|
cmtalbert
:
review+
|
Details | Diff | Splinter Review |
This is a follow-up from bug 760720 which refactored the window map and introduced two new methods which accept the window as parameter and not the id as all the other methods on that object. We should change this so that we are consistent.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #747980 -
Flags: review?(ctalbert)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Clint, ping.
Comment on attachment 747980 [details] [diff] [review]
Patch v1
Review of attachment 747980 [details] [diff] [review]:
-----------------------------------------------------------------
I like this change. Much more clear. r+
Attachment #747980 -
Flags: review?(ctalbert) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Landed on master:
https://github.com/mozilla/mozmill/commit/9acec656077829fc1d5ce8afe1c4e83f028cdcdf
Whiteboard: [ateamtrack: p=mozmill q=2013q2 m=4][mozmill-2.0]
|
|
Assignee | |
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [ateamtrack: p=mozmill q=2013q2 m=4][mozmill-2.0] → [ateamtrack: p=mozmill q=2013q2 m=3][mozmill-2.0]
|
||
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•