870816 - Replace DEBUG_INVALIDATIONS with a pref called nglayout.debug.invalidation

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Watt [:jwatt]]

The fact that you have to change the source and recompile to enable DEBUG_INVALIDATIONS is pretty annoying. I find myself wanting to debug invalidation pretty often.

The "Logging Wish List" section on:

https://wiki.mozilla.org/Gecko:DisplayListBasedInvalidation#Debugging_Invalidations_Problems

says to make it work in release builds too, so I've not kept things behind an ifdef DEBUG.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Hmm, except that this won't compile in opt builds without also moving a whole bunch of other stuff out from #ifdef DEBUG blocks, of course. For now let's keep this simple and just get it working for debug builds.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 748451 [details] [diff] [review]
patch

Review of attachment 748451 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +820,5 @@
>    // to the ThebesLayer's own coordinates
>    nsIntRegion rgn = aRegion;
>    rgn.MoveBy(-aTranslation);
>    aLayer->InvalidateRegion(rgn);
> +#ifdef DEBUG

Change this (and all the others) to MOZ_DUMP_PAINTING, which is what the nsDisplayList debug functions use.

It's always defined in debug, but can be conditionally defined for opt builds too.

Comment 4

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4edb718559c5

I updated the docs.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4edb718559c5