Replace DEBUG_INVALIDATIONS with a pref called nglayout.debug.invalidation

RESOLVED FIXED in mozilla24

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
The fact that you have to change the source and recompile to enable DEBUG_INVALIDATIONS is pretty annoying. I find myself wanting to debug invalidation pretty often.

The "Logging Wish List" section on:

https://wiki.mozilla.org/Gecko:DisplayListBasedInvalidation#Debugging_Invalidations_Problems

says to make it work in release builds too, so I've not kept things behind an ifdef DEBUG.
(Assignee)

Comment 1

5 years ago
Created attachment 747992 [details] [diff] [review]
patch
Attachment #747992 - Flags: review?(mounir)
(Assignee)

Updated

5 years ago
Attachment #747992 - Flags: review?(mounir) → review?(matt.woodrow)
(Assignee)

Comment 2

5 years ago
Created attachment 748451 [details] [diff] [review]
patch

Hmm, except that this won't compile in opt builds without also moving a whole bunch of other stuff out from #ifdef DEBUG blocks, of course. For now let's keep this simple and just get it working for debug builds.
Attachment #747992 - Attachment is obsolete: true
Attachment #747992 - Flags: review?(matt.woodrow)
Attachment #748451 - Flags: review?(matt.woodrow)
Comment on attachment 748451 [details] [diff] [review]
patch

Review of attachment 748451 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +820,5 @@
>    // to the ThebesLayer's own coordinates
>    nsIntRegion rgn = aRegion;
>    rgn.MoveBy(-aTranslation);
>    aLayer->InvalidateRegion(rgn);
> +#ifdef DEBUG

Change this (and all the others) to MOZ_DUMP_PAINTING, which is what the nsDisplayList debug functions use.

It's always defined in debug, but can be conditionally defined for opt builds too.
Attachment #748451 - Flags: review?(matt.woodrow) → review+

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4edb718559c5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.