870902 - [MMS] [UX] Compose: Contacts suggestions has a wrong font. Should be the one designed for our OS.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: Phone screen capture. Shows wrong font use

The font family used to display the contacts suggestion is different from the one used all across de OS. (should be FEURA SANS, or MOZ TT of not updated yet)

Providing screenshot

Comment 1

[Rick Waldron [:rwaldron]]

A repo wide search for the strings "moz tt" and "moztt" comes up with 0 results.

Comment 2

[Victoria Gerchinhoren [:vicky]]

Last week the outdated "Moz TT" font has been erased from the system.
Ping Pavel and Sam Joch to clarify if the new Feura Sans will be the default font in the phone or how to incorporate it.

Comment 3

[Sam Joch [:samjoch]]

AFAIK, Feura Sans is the default font on the device now. That mean you don't need any reference to the font to use Feura Sans. Actually you can use any fonts in css if it embed in the app. 

The system fonts available can be listed with the command: adb shell ls -l /system/fonts

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

I think the problem is here:
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/root.css#L19

I create a patch but I think Sam is busy right now ... and we need to find someone else for r+

Comment 5

[Victoria Gerchinhoren [:vicky]]

Hi Pavel,
What do you want me to give feedback of?

Comment 6

[Corey Frang [:gnarf]]

Comment on attachment 754566 [details]
patch for Gaia repo

Looks good to me, one question though, why the change to using numbers for font-weight?

Comment 7

[Victoria Gerchinhoren [:vicky]]

Corey, I understand it is how they are using it all across the OS. You can better ask to Pavel or Sam Joch  the why.

Comment 8

[Victoria Gerchinhoren [:vicky]]

Corey, I understand it is how they are using it all across the OS. You can better ask to Pavel or Sam Joch  the why.

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Corey,
we just trying to keep some convention it's not a problem. here https://wiki.mozilla.org/Gaia/CSS_Guidelines we have some guidelines, bug we need to put some rules for font if you want feel free to put them there

Comment 10

[Corey Frang [:gnarf]]

Comment on attachment 754566 [details]
patch for Gaia repo

r=me - sorry i took so long, never saw the followup comment

Comment 11

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/021032e0ad73b7837b5fb92832ebb43b63608001

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 021032e0ad73b7837b5fb92832ebb43b63608001 to:
v1-train: 0bc63c0048cc94157993d2da1fa43fca8717c4e6