870959 - don't include Preferences.h or NonRefcountedDOMObject.h in bindings unless necessary

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: don't include Preferences.h or NonRefcountedDOMObject.h in bindings unless necessary

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 748166 [details] [diff] [review]
don't include Preferences.h or NonRefcountedDOMObject.h in bindings unless necessary

>+        def descriptorRequiresPreferences(desc):

I think I'd prefer this function to look like this:

  iface = desc.iface
  return any(m.getExtendedAttribute("Pref") for m in iface.members + [iface])

In particular, you shouldn't need Preferences.h for a [Func] on a member, I don't think, nor for [PrefControlled] on an interface.

>+        requiresPreferences = any(map(descriptorRequiresPreferences, descriptors))

I'd prefer any(descriptorRequiresPreferences(d) for d in descriptors) so it can stop once it finds one...

>+        hasNativeOwnership = any(map(lambda d: d.nativeOwnership == 'owned',

How about calling that variable hasOwnedDescriptors?

And again, any(d.nativeOwnership == 'owned' for d in descriptors).

r=me

          hasNativeOwnership = any(

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90103dbe8f38

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/90103dbe8f38