Refactor mediaGallery to allow for different page type make API responses

RESOLVED FIXED

Status

Webmaker
webmaker.org
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: ednapiranha, Assigned: ednapiranha)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Just adjusting some stuff in mediaGallery.js so that it is more reusable
(Assignee)

Comment 1

5 years ago
Created attachment 748183 [details] [review]
https://github.com/mozilla/webmaker.org/pull/16

Ross, I'll be in MV next week so if it's r+ feel free to merge in for me - thanks!
Attachment #748183 - Flags: review?(ross)

Comment 2

5 years ago
Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/02e81abf68f4965cf35021a5d457cf49cd0e6292
refactor mediaGallery to support multiple pages; bug 870982

https://github.com/mozilla/webmaker.org/commit/f64b2aa792712f092058ff190824486c51cf0dce
Merge pull request #16 from ednapiranha/teach

refactor mediaGallery to support multiple pages; bug 870982
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 748183 [details] [review]
https://github.com/mozilla/webmaker.org/pull/16

I still get emails about needing a review on this :(
Attachment mime type: text/plain → text/x-github-pull-request
(Assignee)

Updated

4 years ago
Attachment #748183 - Flags: review?(rossbruniges) → review+
(Assignee)

Updated

4 years ago
Attachment #748183 - Flags: review+
You need to log in before you can comment on or make changes to this bug.