871055 - [MMS] [UX] Thread view. Wrong spacing between Image thumbnail and text below it

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: indicates correct spacing between the two elements in the bubble

Inside the bubble in the messages thread: between the image thumbnail and the text message it should be a space of 15px.
See attachment that ilustrates it

Comment 1

[Mike Pennisi [:jugglinmike]]

Attachment: Correct MMS media spacing

Comment 2

[Mike Pennisi [:jugglinmike]]

Attachment: Patch applied

This screenshot demonstrates the effect of the patch.

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 753431 [details] [diff] [review]
Correct MMS media spacing

r=me

ask victoria before landing. I'm ok with whatever value you'd throw in the margin following Victoria's advice.

Comment 4

[Mike Pennisi [:jugglinmike]]

Hi Vivien,

The description of this bug specifies a margin of "15px". However, attachment 753321 [details] (from Bug 870950) specifies a margin of "10px". Could you clarify which measurement we should use?

Comment 5

[Mike Pennisi [:jugglinmike]]

I meant to say, "Hi Victoria"! Sorry about that!

Comment 6

[Victoria Gerchinhoren [:vicky]]

Hi Mike, Yes, please make it 10. Modules are of 15 px in the bubbles, but it would take too much vertical space. Thanks!

Comment 7

[Mike Pennisi [:jugglinmike]]

Landed at commit fd1ddaedc0e7703d796e9dff3d1d24cba8c5490b

Thanks for clarification, Victoria, and thanks for the review, Julien

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted fd1ddaedc0e7703d796e9dff3d1d24cba8c5490b to:
v1-train: 1ad346ccf9a30b5fa8493533c240f0eb7e74457b

Comment 9

[Deepa Subramanian]

The user is able to see able to see spacing between the text and message.
Verifying as fixed.

Environmental Variables
LEO Build ID: 20130807071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/11bb1b0eefff
Gaia: 60ca81600a080dae33058b0692ecaa213556c926
Platform Version: 18.1