Open Bug 871163 Opened 11 years ago Updated 2 years ago

Fix nsOverflowContinuationTracker::SetUpListWalker()

Categories

(Core :: Layout: Block and Inline, defect)

defect

Tracking

()

People

(Reporter: MatsPalmgren_bugz, Unassigned)

Details

From fantasai in bug 850931 comment #26:
> In Comment 4 you wrote that mPrevOverflowCont is the NIF of the
> aOverflowCont we're trying to insert. That's clearly broken, and is what
> should be fixed.
> 
> It looks like mPrevOveflowCont became that NIF when we were setting up the
> list walker (walking over the OC continuations, one of which was
> aOverflowCont's NIF). What we probably should be doing is checking that the
> OC continuations that we're skipping are the ones we want to keep in this
> list, and we can check that by checking that their prev-in-flow's parent is
> our prev-in-flow.
> 
> Any OC continuations whose prev-in-flow is not parented by our prev-in-flow
> don't belong on this list. They have to be kept somewhere, but that should
> be at the end of the list (because that maintains continuation order) and
> should not be encountered by our walker or reflowed by
> ReflowOverflowContainerChildren. (They'll eventually be pushed out to
> another frame further down the continuation chain, and should be placed
> correctly once their immediate prev-in-flow is reflowed. We just need to own
> them until that happens.)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.