871184 - [webvtt] HTMLTrackElement kind enum list should be case-insensitive

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Marcus Saad (:msaad)]

The enumerated list that represents the possible values for kind should always return case case-insensitive values.

Comment 1

[Marcus Saad (:msaad)]

Attachment: Test Case - HTMLTrackElement kind enum list

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This should simply not be an enum.

Comment 3

[Rick Eyre (:reyre)]

This test case actually works perfectly fine for me. We're also using the case insensitive version of nsAttrValue::ParseEnumValue. So we're handling this behaviour correctly as of now.

It would be useful to include this in the current suite of DOM tests so I'll make sure to do that when updating bug 833386.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

There is a still a bug, though.

track.kind = "foo";
is(track.getAttribute("kind"), "foo");

should pass.

Comment 5

[Caitlin Potter (:caitp)]

according to the draft, all of the track attributes are read only, except for "mode". this should not pass

Comment 6

[Rick Eyre (:reyre)]

I've been wondering about that too. If you try to set though HTMLTrackElement.[prop] it won't work, which is the behaviour we want. However, using the setAttribute() like in this test case works.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

interface HTMLTrackElement : HTMLElement {
           attribute TextTrackKind kind;
           attribute DOMString src;
           attribute DOMString srclang;
           attribute DOMString label;
           attribute boolean default;

  const unsigned short NONE = 0;
  const unsigned short LOADING = 1;
  const unsigned short LOADED = 2;
  const unsigned short ERROR = 3;
  readonly attribute unsigned short readyState;

  readonly attribute TextTrack track;
};

Comment 8

[Caitlin Potter (:caitp)]

yes,i was referring to TextTrack, different interface.

Comment 9

[Rick Eyre (:reyre)]

Marking this as resolved as it is currently properly working with case-insensitive values.

Will open a new bug for possibly changing HTMLTrackElement.kind from an enum to DOMString as per Ms2ger's requests.