[webvtt] HTMLTrackElement readyState attribute assigning random values

RESOLVED FIXED

Status

()

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: msaad, Unassigned)

Tracking

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
HTMLTrackElement is assigning random numbers to readyState. Acceptable values are between 0 and 3 included.
(Reporter)

Comment 1

6 years ago
Created attachment 748478 [details]
Test Case - HTMLTrackElement readyState improver value.
(Reporter)

Comment 2

6 years ago
We should come to a common sense of which value to set by default. I personally think that 0 is the best value, so that it can be updated as needed.

//Possible values for readyState
  enum {
    NONE = 0U,
    LOADING = 1U,
    LOADED = 2U,
    ERROR = 3U
  };
(Reporter)

Updated

6 years ago
Blocks: 833385

Updated

6 years ago
Blocks: 833386
No longer blocks: 833385
I haven't been able to reproduce this with rev 134626:86413e921d5d

The test is passing consistently. Was this fixed somewhere else?

Comment 4

5 years ago
I think it was fixed while bug 833385 was being reviewed. I'm in the middle of updating 833386 to include tests for this as well so I think we should be covered on it.
```
HTMLTrackElement::HTMLTrackElement(already_AddRefed<nsINodeInfo> aNodeInfo)
  : nsGenericHTMLElement(aNodeInfo)
  , mReadyState(NONE)
```

mReadyState is being initiallized now, as of some point. So it should never be random, anyways. WFM, resolved
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.