871259 - Fix rooting hazards in ContextWrapperChild.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Wrong patch!

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 748525 [details] [diff] [review]
Patch (v1)

Review of attachment 748525 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/ipc/ContextWrapperChild.h
@@ +29,5 @@
>      }
>  
>      JSContext* GetContext() { return mContext; }
>  
> +    PObjectWrapperChild* GetOrCreateWrapper(JSObject* obj_,

I keep forgetting that we don't do handle-ization outside of SpiderMonkey. Seems like a waste to me not to use a handle here, as I'd pretty much bet that all callers already root obj_.

Not a request to change anything here, though. More like something the js team should discuss during the work week.

Comment 3

[(no longer active)]

OK, so I'll just land this patch then!

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea5b67dee563

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea5b67dee563