Closed
Bug 871301
Opened 12 years ago
Closed 12 years ago
Remove JS_GetGlobalObject from nsCrypto and nsDirectoryViewer
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: bholley, Assigned: bholley)
References
Details
(Whiteboard: [LeoVB+])
Attachments
(1 file, 1 obsolete file)
|
3.83 KB,
patch
|
bzbarsky
:
review+
lsblakk
:
approval-mozilla-beta+
lsblakk
:
approval-mozilla-esr17+
lsblakk
:
approval-mozilla-b2g18+
|
Details | Diff | Splinter Review |
Just some miscellaneous culprits that don't fit anywhere else...
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #748569 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Lets modernize the cx pushing while we're at it.
Attachment #748569 -
Attachment is obsolete: true
Attachment #748569 -
Flags: review?(bzbarsky)
Attachment #748935 -
Flags: review?(bzbarsky)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 748935 [details] [diff] [review]
Remove JS_GetGlobalObject from nsCrypto and nsDirectoryViewer. v2
r=me
Attachment #748935 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 748935 [details] [diff] [review]
Remove JS_GetGlobalObject from nsCrypto and nsDirectoryViewer. v2
We've gotten reports that this fixes longstanding stability issues in popular russian websites that use some of these random crypto APIs. I discussed this with akeybl, and we decided to take this on branches to see if we can reduce some of the pain here.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): longstanding
User impact if declined: stability issues
Testing completed (on m-c, etc.): baked on m-c and m-a
Risk to taking this patch (and alternatives if risky): very low risk
String or IDL/UUID changes made by this patch: none
Attachment #748935 -
Flags: approval-mozilla-esr17?
Attachment #748935 -
Flags: approval-mozilla-beta?
Attachment #748935 -
Flags: approval-mozilla-b2g18?
|
||
Updated•11 years ago
|
Attachment #748935 -
Flags: approval-mozilla-esr17?
Attachment #748935 -
Flags: approval-mozilla-esr17+
Attachment #748935 -
Flags: approval-mozilla-beta?
Attachment #748935 -
Flags: approval-mozilla-beta+
Attachment #748935 -
Flags: approval-mozilla-b2g18?
Attachment #748935 -
Flags: approval-mozilla-b2g18+
|
|
||
Comment 9•11 years ago
|
||
b2g18 is closed at the moment, but it's in my queue to land there once it reopens.
https://hg.mozilla.org/releases/mozilla-beta/rev/59c478137f1e
https://hg.mozilla.org/releases/mozilla-esr17/rev/206dba739a7b
status-b2g18:
--- → affected
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-b2g-v1.1hd:
--- → affected
status-firefox23:
--- → fixed
status-firefox24:
--- → fixed
status-firefox-esr17:
--- → fixed
|
|
||
Comment 10•11 years ago
|
||
|
||
Updated•11 years ago
|
Whiteboard: [LeoVB+]
|
|
Assignee | |
Comment 12•11 years ago
|
||
(In reply to Bogdan Maris [QA] [:bogdan_maris] from comment #11)
> Is there a way I can manually test this fix?
Probably not. I wouldn't worry about it.
Flags: needinfo?
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•