8714 - duplicate window ID causes infinite loop

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Alec Flett]

If you use an entity, with &entityName; and it's not defined in the document,
you get an ASSERT:

> Assertion: "must have content" (aContent) at file nsStyleSet.cpp, line 517
>

And then an infinite  loop of some kind...sometimes I've seen it do a recursive
loop, other times not, but in anycase, the content does not draw, and the app is
basically locked up.

Comment 1

[rickg]

Chris -- I've checked this on NT and it works for me. Can you verify it on Win95
and Unix please?

Comment 2

[Chris Petersen]

With latest build (1999062810), I can't reproduce the problem described. Works
for me.

Comment 3

[Chris Petersen]

With latest build (1999062810), I can't reproduce the problem described. Works

for me.

Comment 4

[Alec Flett]

I just figured out the infinite loop problem - it happens when the <window> id
is the same as an id in the xul document.

So

<window (setup XUL namespaces, etc) id="abcd">
<titledbutton id="abcd"/>
</window>

will cause infinite recursion.

This might happen when ANY elements have the same ID, I'm not sure.

Comment 5

[rickg]

Peter -- this appears to be a XUL problem, not an entity problem. Please have
one of your guys take a gander.

Comment 6

[Peter Trudelle]

assigning to hyatt as p1 for m8

Comment 7

[David Hyatt]

cc'ing waterson. Moving to M10.

Comment 8

[Chris Waterson]

Sorry, HYatt. This one is mine all mine.

Comment 9

[Chris Waterson]

Uh, ok. I think the immediate rx for this is, "don't do that". Moving out to
M15.

Comment 10

[Alec Flett]

but of course... eventually we gotta fix this though - this is also a denial of
service attack if content can hang the browser with content! :)

Comment 11

[Chris Petersen]

Alec, could you please check to see if this problem has been fixed in the latest
build ? I'm not able to repo the problem.

Comment 12

[Alec Flett]

I'll take your word for it.
this XUL would make it go into an infinite loop:

<window id="abcd">
  <titledbutton id="abcd" value="hi there"/>
</window>

Comment 13

[Chris Petersen]

I don't see this problem with the Oct 28th Linux build. Marking as verified

fixed.

Comment 14

[Chris Petersen]

I don't see this problem with the Oct 28th Linux build. Marking as verified

fixed.

Comment 15

[leger]

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.